Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1220)

Unified Diff: Source/core/inspector/InjectedScriptSource.js

Issue 295633003: Show information about Symbols in DevTools console. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/devtools/protocol.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/InjectedScriptSource.js
diff --git a/Source/core/inspector/InjectedScriptSource.js b/Source/core/inspector/InjectedScriptSource.js
index d4d366d4fb37a7295c481aa3649d388adb629560..a9c1b4c1049c2d1f1f2f222e67f46ae6606ece5b 100644
--- a/Source/core/inspector/InjectedScriptSource.js
+++ b/Source/core/inspector/InjectedScriptSource.js
@@ -1008,6 +1008,9 @@ InjectedScript.prototype = {
if (typeof obj === "function")
return toString(obj);
+ if (typeof obj === "symbol")
+ return Symbol.prototype.toString.call(obj);
yurys 2014/05/22 15:25:49 toString(obj) as Symbol.prototype.toString can be
aandrey 2014/05/22 15:29:50 We already use Object.prototype.toString in the co
aandrey 2014/05/22 15:31:12 wrap it in try-catch
yurys 2014/05/22 15:49:37 I'm wondering if the conversion is prohibited by t
Alexandra Mikhaylova 2014/05/22 16:07:59 Done, wrapped in a try-catch block.
+
if (className === "Object") {
// In Chromium DOM wrapper prototypes will have Object as their constructor name,
// get the real DOM wrapper name from the constructor property.
« no previous file with comments | « no previous file | Source/devtools/protocol.json » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698