Don't disable fec for packets without timing frames extension, even if

Don't disable FEC if timing frames are disabled.

Don't disable fec for packets without timing frames extension
even if they are marked as belonging to timing frames.

BUG=webrtc:7894
Review-Url: https://codereview.webrtc.org/2956263002
Cr-Commit-Position: refs/heads/master@{#18826}
Committed: https://chromium.googlesource.com/external/webrtc/+/e4350197ecd85bf1bd47e5f3e205f76239631e00

[ilnik, 2017-06-28 13:14:18]

ilnik@webrtc.org changed reviewers:
+ brandtr@webrtc.org

[ilnik, 2017-06-28 13:14:18]

Even if timing frames extension is disabled (as in e2e FEC tests), some packets
were not protected by FEC. This Cl fixes that.

[ilnik, 2017-06-28 13:52:42]

The CQ bit was checked by ilnik@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-28 13:52:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-28 14:05:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-28 14:05:25]

Dry run: Try jobs failed on following builders:
  linux_ubsan on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan/builds/13447)

[ilnik, 2017-06-29 08:24:01]

The CQ bit was checked by ilnik@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-29 08:24:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-29 08:45:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-29 08:45:08]

Dry run: This issue passed the CQ dry run.

[brandtr, 2017-06-29 08:51:32]

lgtm, but please rephrase first row of commit message to be below ~60
characters. Add details in second paragraph of commit message.

I'm not an OWNER in rtp_rtcp/, so maybe check with danilchap@ too.

[ilnik, 2017-06-29 08:53:21]

Description was changed from

==========
Don't disable fec for packets without timing frames extension, even if
they are marked as timing frames

BUG=webrtc:7894
==========

to

==========
Don't disable FEC if timing frames are disabled.

Don't disable fec for packets without timing frames extension
even if they are marked as belonging to timing frames.

BUG=webrtc:7894
==========

[ilnik, 2017-06-29 08:54:20]

ilnik@webrtc.org changed reviewers:
+ asapersson@webrtc.org

[ilnik, 2017-06-29 08:54:53]

On 2017/06/29 08:51:32, brandtr wrote:
> lgtm, but please rephrase first row of commit message to be below ~60
> characters. Add details in second paragraph of commit message.
> 
> I'm not an OWNER in rtp_rtcp/, so maybe check with danilchap@ too.

+Asapersson,

[åsapersson, 2017-06-29 09:20:36]

lgtm

[ilnik, 2017-06-29 09:25:10]

The CQ bit was checked by ilnik@webrtc.org

[commit-bot: I haz the power, 2017-06-29 09:25:22]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-06-29 09:27:45]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498728310989840,
"parent_rev": "8d08a92c052b985ca540a5c9928f11a6e11a019c", "commit_rev":
"efb0fc7577548c761fcbe843d7b83c5ae0f4d822"}

[commit-bot: I haz the power, 2017-06-29 09:27:48]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1498728310989840,
"parent_rev": "8c1ee7b73a85c74ded5a928f4f0c8eacc7d6f24d", "commit_rev":
"e4350197ecd85bf1bd47e5f3e205f76239631e00"}

[commit-bot: I haz the power, 2017-06-29 09:27:52]

Description was changed from

==========
Don't disable FEC if timing frames are disabled.

Don't disable fec for packets without timing frames extension
even if they are marked as belonging to timing frames.

BUG=webrtc:7894
==========

to

==========
Don't disable FEC if timing frames are disabled.

Don't disable fec for packets without timing frames extension
even if they are marked as belonging to timing frames.

BUG=webrtc:7894

Review-Url: https://codereview.webrtc.org/2956263002
Cr-Commit-Position: refs/heads/master@{#18826}
Committed:
https://chromium.googlesource.com/external/webrtc/+/e4350197ecd85bf1bd47e5f3e...
==========

[commit-bot: I haz the power, 2017-06-29 09:27:53]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/e4350197ecd85bf1bd47e5f3e...