Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2956243002: Add SetCodecSettings method for configuring VideoCodec settings. (Closed)

Created:
3 years, 5 months ago by åsapersson
Modified:
3 years, 5 months ago
Reviewers:
brandtr
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add SetCodecSettings method for configuring VideoCodec settings. Remove video codec settings from CodecParams (and rename to ProcessParams). Removes intermediate step of configuring video settings via CodecParams. BUG=webrtc:6634 Review-Url: https://codereview.webrtc.org/2956243002 Cr-Commit-Position: refs/heads/master@{#18830} Committed: https://chromium.googlesource.com/external/webrtc/+/8a90f87518cc01dce1e9e2e835ad10c3abb55b9a

Patch Set 1 #

Patch Set 2 #

Total comments: 2

Patch Set 3 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -226 lines) Patch
M webrtc/modules/video_coding/codecs/test/plot_videoprocessor_integrationtest.cc View 2 chunks +9 lines, -7 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor.h View 1 2 5 chunks +15 lines, -21 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor.cc View 1 2 1 chunk +0 lines, -17 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.h View 1 12 chunks +95 lines, -137 lines 0 comments Download
M webrtc/modules/video_coding/codecs/test/videoprocessor_integrationtest.cc View 1 16 chunks +64 lines, -44 lines 0 comments Download

Messages

Total messages: 21 (16 generated)
åsapersson
3 years, 5 months ago (2017-06-28 14:04:20 UTC) #9
brandtr
lgtm https://codereview.webrtc.org/2956243002/diff/60001/webrtc/modules/video_coding/codecs/test/videoprocessor.cc File webrtc/modules/video_coding/codecs/test/videoprocessor.cc (right): https://codereview.webrtc.org/2956243002/diff/60001/webrtc/modules/video_coding/codecs/test/videoprocessor.cc#newcode102 webrtc/modules/video_coding/codecs/test/videoprocessor.cc:102: TestConfig::TestConfig() {} Might as well remove ctor and ...
3 years, 5 months ago (2017-06-29 09:04:04 UTC) #10
åsapersson
https://codereview.webrtc.org/2956243002/diff/60001/webrtc/modules/video_coding/codecs/test/videoprocessor.cc File webrtc/modules/video_coding/codecs/test/videoprocessor.cc (right): https://codereview.webrtc.org/2956243002/diff/60001/webrtc/modules/video_coding/codecs/test/videoprocessor.cc#newcode102 webrtc/modules/video_coding/codecs/test/videoprocessor.cc:102: TestConfig::TestConfig() {} On 2017/06/29 09:04:04, brandtr wrote: > Might ...
3 years, 5 months ago (2017-06-29 10:32:15 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2956243002/80001
3 years, 5 months ago (2017-06-29 12:11:11 UTC) #18
commit-bot: I haz the power
3 years, 5 months ago (2017-06-29 12:13:33 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:80001) as
https://chromium.googlesource.com/external/webrtc/+/8a90f87518cc01dce1e9e2e83...

Powered by Google App Engine
This is Rietveld 408576698