[Android] Enable WebAPK to have multiple intent filters

chrome/android/webapk/shell_apk/AndroidManifest.xml

 <?xml version="1.0" encoding="utf-8"?>
 <!-- Copyright 2015 The Chromium Authors. All rights reserved.
      Use of this source code is governed by a BSD-style license that can be
      found in the LICENSE file.
 -->
 <manifest xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:tools="http://schemas.android.com/tools"
     package="{{{manifest_package}}}"
     android:versionCode="{{{version_code}}}"
     android:versionName="{{{version_name}}}" >
 
     <uses-sdk
         android:minSdkVersion="16"
         android:targetSdkVersion="23" />
 
     <application
         android:icon="@mipmap/app_icon"
         android:label="@string/short_name"
         android:allowBackup="false">
         <activity android:name="org.chromium.webapk.shell_apk.MainActivity"
                   android:theme="@android:style/Theme.Translucent.NoTitleBar"
                   android:excludeFromRecents="true">
             <intent-filter>
                 <action android:name="android.intent.action.MAIN" />
                 <category android:name="android.intent.category.LAUNCHER" />
             </intent-filter>
+            {{#intent_filters:intent_filters}}

[Yaron, 2017/06/28 16:55:40]

I'm not familiar with this syntax but have you verified it works with the server
implementation?

[hartmanng, 2017/06/28 18:24:33]

it doesn't as-is. The changes to make it work on the server are easy, but I
can't promise it'll still work on the client afterwards...

Changes required:
- the server doesn't like {{#intent_filters:intent_filters}} ("interleaved
closing tag: intent_filters"), but seems to work fine with just
{{#intent_filters}}.
- the "inner" variables ("intent_filters.scope_url_scheme", etc) don't expect
the "intent_filters." prefix on the server implementation. They seem to just
want "scope_url_scheme". 

[Yaron, 2017/06/28 18:28:47]

Ya, those match my expectations. I would think that it would work on the client
but I've been (unpleasantly) surprised by its impl before

[pkotwicz, 2017/06/28 20:45:06]

It doesn't. The server will have the process the AndroidManifest.xml to convert
the MoTemplate syntax to Mustache.

Converting from MoTemplate to Mustache is easy. (Remove the text before the ':')

For the sake of clarity, MoTemplate rejects the Mustache syntax that you are
familiar with

[hartmanng, 2017/06/28 21:01:29]

Just to be completely explicit here: the part of this comment that says "The
server will have the process the AndroidManifest.xml to convert the MoTemplate
syntax to Mustache" is no longer true in the most recent patchset, correct?

             <intent-filter>
                 <action android:name="android.intent.action.VIEW"></action>
                 <category android:name="android.intent.category.DEFAULT"></category>
                 <category android:name="android.intent.category.BROWSABLE"></category>
-                <data android:scheme="{{{scope_url_scheme}}}" android:host="{{{scope_url_host}}}" android:pathPrefix="{{{scope_url_path}}}"></data>
+                <data android:scheme="{{{intent_filters.scope_url_scheme}}}" android:host="{{{intent_filters.scope_url_host}}}" android:pathPrefix="{{{intent_filters.scope_url_path}}}"></data>
             </intent-filter>
+            {{/intent_filters}}
         </activity>
         <meta-data android:name="org.chromium.webapk.shell_apk.shellApkVersion" android:value="{{{shell_apk_version}}}" />
-        {{#runtime_host}}<meta-data android:name="org.chromium.webapk.shell_apk.runtimeHost" android:value="{{{runtime_host}}}" />{{/runtime_host}}
-        {{#runtime_host_application_name}}<meta-data android:name="org.chromium.webapk.shell_apk.runtimeHostApplicationName" android:value="{{{runtime_host_application_name}}}" />{{/runtime_host_application_name}}
+        {{#bound_webapk}}
+        <meta-data android:name="org.chromium.webapk.shell_apk.runtimeHost" android:value="{{{runtime_host}}}" />
+        <meta-data android:name="org.chromium.webapk.shell_apk.runtimeHostApplicationName" android:value="{{{runtime_host_application_name}}}" />
+        {{/bound_webapk}}
         <meta-data android:name="org.chromium.webapk.shell_apk.startUrl" android:value="{{{start_url}}}" />
         <meta-data android:name="org.chromium.webapk.shell_apk.scope" android:value="{{{scope_url}}}" />
         <meta-data android:name="org.chromium.webapk.shell_apk.displayMode" android:value="{{{display_mode}}}" />
         <meta-data android:name="org.chromium.webapk.shell_apk.orientation" android:value="{{{orientation}}}" />
         <meta-data android:name="org.chromium.webapk.shell_apk.themeColor" android:value="{{{theme_color}}}" />
         <meta-data android:name="org.chromium.webapk.shell_apk.backgroundColor" android:value="{{{background_color}}}" />
         <meta-data android:name="org.chromium.webapk.shell_apk.iconId" android:resource="@mipmap/app_icon" />
+
+        <!-- Hashes of icons should be taken of the icons as they are available on the web. The icon

[Yaron, 2017/06/28 16:59:39]

Use mustache comment {{! instaed

[pkotwicz, 2017/06/28 20:45:06]

Done.

Does Android keep XML comments when it constructs the .apk?

+             bytes should not be transformed (e.g. decoded / encoded) prior to taking the hash.
+          -->
         <meta-data android:name="org.chromium.webapk.shell_apk.iconUrlsAndIconMurmur2Hashes" android:value="{{{icon_urls_and_icon_murmur2_hashes}}}" />
+
         <meta-data android:name="org.chromium.webapk.shell_apk.webManifestUrl" android:value="{{{web_manifest_url}}}" />
         <service
             android:name="org.chromium.webapk.shell_apk.WebApkServiceFactory"
             android:exported="true"
             tools:ignore="ExportedService">
             <intent-filter>
               <action android:name="android.intent.action.MAIN" />
               <category android:name="android.intent.category.WEBAPK_API" />
             </intent-filter>
         </service>
@@ skipping 11 matching lines @@
             android:process=":webapk_sandboxed_process1"
             android:exported="true"
             tools:ignore="ExportedService"/>
         <service android:name="org.chromium.webapk.shell_apk.WebApkSandboxedProcessService2"
             android:isolatedProcess="true"
             android:process=":webapk_sandboxed_process2"
             android:exported="true"
             tools:ignore="ExportedService"/>
     </application>
 </manifest>