Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Unified Diff: components/sync/protocol/printer_specifics.proto

Issue 2956173002: Introduce the field make_and_model for synced printers. (Closed)
Patch Set: done Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/printing/printer_translator_unittest.cc ('k') | components/sync/protocol/proto_visitors.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/protocol/printer_specifics.proto
diff --git a/components/sync/protocol/printer_specifics.proto b/components/sync/protocol/printer_specifics.proto
index 9713d6329081a587d73966c3c5e6ab3edfa5b59e..b9ada32d3163c99d8938877d6db8261e27c5047a 100644
--- a/components/sync/protocol/printer_specifics.proto
+++ b/components/sync/protocol/printer_specifics.proto
@@ -41,10 +41,12 @@ message PrinterSpecifics {
optional string description = 3;
// Printer manufacturer. Should be a known manufacturuer.
- optional string manufacturer = 4;
+ // Deprecated in favor of make_and_model.
+ optional string manufacturer = 4 [deprecated = true];
// Printer model. Should match a known model for the manufacturer.
- optional string model = 5;
+ // Deprecated in favor of make_and_model.
+ optional string model = 5 [deprecated = true];
// Universal Resource Identifier for the printer on the network. usb:// will
// be the scheme for USB printers. Example
@@ -63,4 +65,9 @@ message PrinterSpecifics {
// Timestamp when printer was last updated.
optional int64 updated_timestamp = 10;
+
+ // The make and model of the printer in one string. The typical arrangement
+ // for this is '<make> <model>'. This aligns with the typical formatting of
+ // the IPP attribute printer-make-and-model.
+ optional string make_and_model = 11;
}
« no previous file with comments | « chromeos/printing/printer_translator_unittest.cc ('k') | components/sync/protocol/proto_visitors.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698