Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: components/sync/protocol/printer_specifics.proto

Issue 2956173002: Introduce the field make_and_model for synced printers. (Closed)
Patch Set: address comments. Add test Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Sync protocol datatype extension for printer data. 5 // Sync protocol datatype extension for printer data.
6 6
7 // Update proto_value_conversions{.h,.cc,_unittest.cc} if you change 7 // Update proto_value_conversions{.h,.cc,_unittest.cc} if you change
8 // any fields in this file. 8 // any fields in this file.
9 9
10 syntax = "proto2"; 10 syntax = "proto2";
(...skipping 23 matching lines...) Expand all
34 // Printer record GUID 34 // Printer record GUID
35 optional string id = 1; 35 optional string id = 1;
36 36
37 // User visible name. Any string. 37 // User visible name. Any string.
38 optional string display_name = 2; 38 optional string display_name = 2;
39 39
40 // User visible description. Any string. 40 // User visible description. Any string.
41 optional string description = 3; 41 optional string description = 3;
42 42
43 // Printer manufacturer. Should be a known manufacturuer. 43 // Printer manufacturer. Should be a known manufacturuer.
44 optional string manufacturer = 4; 44 // Deprecated in favor of make_and_model.
45 optional string manufacturer = 4 [deprecated = true];
45 46
46 // Printer model. Should match a known model for the manufacturer. 47 // Printer model. Should match a known model for the manufacturer.
47 optional string model = 5; 48 // Deprecated in favor of make_and_model.
49 optional string model = 5 [deprecated = true];
48 50
49 // Universal Resource Identifier for the printer on the network. usb:// will 51 // Universal Resource Identifier for the printer on the network. usb:// will
50 // be the scheme for USB printers. Example 52 // be the scheme for USB printers. Example
51 // ipp://address.example:port/queue/queue/queue. 53 // ipp://address.example:port/queue/queue/queue.
52 optional string uri = 6; 54 optional string uri = 6;
53 55
54 // Universally Unique Identifier provided by the printer. Used for unique 56 // Universally Unique Identifier provided by the printer. Used for unique
55 // identification of printers in a zeroconf environment. 57 // identification of printers in a zeroconf environment.
56 optional string uuid = 7; 58 optional string uuid = 7;
57 59
58 // PPDData was deprecated in favor of PPDReference format. 60 // PPDData was deprecated in favor of PPDReference format.
59 optional bytes ppd = 8 [deprecated = true]; 61 optional bytes ppd = 8 [deprecated = true];
60 62
61 // Structure representing the user's ppd configuration. 63 // Structure representing the user's ppd configuration.
62 optional PrinterPPDReference ppd_reference = 9; 64 optional PrinterPPDReference ppd_reference = 9;
63 65
64 // Timestamp when printer was last updated. 66 // Timestamp when printer was last updated.
65 optional int64 updated_timestamp = 10; 67 optional int64 updated_timestamp = 10;
68
69 // The make and model of the printer in one string. The typical arrangement
70 // for this is '<Make> <Model>'. This aligns with the typical formatting of
skym 2017/06/28 22:14:33 Not that it really matters, but you're not being c
skau 2017/06/28 22:41:06 Done.
71 // the IPP attribute printer-make-and-model.
72 optional string make_and_model = 11;
66 } 73 }
OLDNEW
« no previous file with comments | « chromeos/printing/printer_translator_unittest.cc ('k') | components/sync/protocol/proto_visitors.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698