Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: build/android/stacktrace/BUILD.gn

Issue 2956153003: android: Convert java_deobfuscate.py to Java (Closed)
Patch Set: OWNERS Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/android/stacktrace/BUILD.gn
diff --git a/build/android/stacktrace/BUILD.gn b/build/android/stacktrace/BUILD.gn
new file mode 100644
index 0000000000000000000000000000000000000000..307cfa42dcabcbf12aacdf1ca4a5a0c915e35559
--- /dev/null
+++ b/build/android/stacktrace/BUILD.gn
@@ -0,0 +1,19 @@
+# Copyright 2017 The Chromium Authors. All rights reserved.
Yaron 2017/06/28 15:55:25 Move to tools/android
agrieve 2017/06/29 01:59:20 My intention is to have test_runner.py use this to
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import("//build/config/android/rules.gni")
+
+java_binary("java_deobfuscate") {
+ main_class = "org.chromium.build.FlushingReTrace"
+ java_files = [ "java/org/chromium/build/FlushingReTrace.java" ]
+ deps = [
+ "//third_party/proguard:retrace_java",
+ ]
+ data = [
+ "$root_build_dir/lib.java/build/android/stacktrace/java_deobfuscate.jar",
Yaron 2017/06/28 15:55:25 weird that you have to re-list jars and they aren'
agrieve 2017/06/29 01:59:20 This is so that they will be available to swarming
+ "$root_build_dir/lib.java/third_party/proguard/proguard.jar",
jbudorick 2017/06/28 16:11:38 Shouldn't these two be handled by //third_party/pr
agrieve 2017/06/29 01:59:20 If someone wanted to go the dist_jar() route, then
+ "$root_build_dir/lib.java/third_party/proguard/retrace.jar",
+ "$root_build_dir/bin/java_deobfuscate",
+ ]
+}

Powered by Google App Engine
This is Rietveld 408576698