Issue 295613003: Oilpan: make MediaError + TrackEvent heap savvier.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 295613003: Oilpan: make MediaError + TrackEvent heap savvier. (Closed)

Created:
6 years, 7 months ago by sof

Modified:
6 years, 7 months ago

Reviewers:
oilpan-reviews, haraken

CC:
blink-reviews, blink-reviews-html_chromium.org, arv+blink, philipj_slow, gasubic, fs, eric.carlson_apple.com, watchdog-blink-watchlist_google.com, feature-media-reviews_chromium.org, dglazkov+blink, nessy, Inactive, vcarbune.chromium

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Oilpan: make MediaError + TrackEvent heap savvier. With the media element now on the heap, move MediaError over + have TrackEvent keep a Member reference to its track object. R=haraken@chromium.org BUG=357163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174277

Patch Set 1 #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -9 lines)			Patch
M	Source/core/html/HTMLMediaElement.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/core/html/HTMLMediaElement.cpp	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	Source/core/html/MediaError.h	View	2 chunks	+7 lines, -2 lines	0 comments	Download
M	Source/core/html/MediaError.idl	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	Source/core/html/track/TrackEvent.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/track/TrackEvent.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/295613003/1

6 years, 7 months ago (2014-05-19 08:14:51 UTC) #4

Message was sent while issue was closed.

Change committed as 174277

Expand Messages | Collapse Messages