Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 295613002: DevTools: handle Tracing.start in both browser and renderer (Closed)

Created:
6 years, 7 months ago by yurys
Modified:
6 years, 7 months ago
Reviewers:
caseq, pfeldman
CC:
chromium-reviews, vsevik, jam, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Visibility:
Public.

Description

DevTools: handle Tracing.start in both browser and renderer DevToolsTracingHandler is used for inspecting two different targets: browser and renderer. The former one is used by Telemetry and behavior in that case hasn't changed. When the handler is used for inslecting renderer we do not return response from browser override for Tracing.start so that InspectorTracingAgent in the render process could handle it. For blink counterpart, see: https://codereview.chromium.org/254613002 BUG=361045, 374411 R=caseq@chromium.org, pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271368

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -9 lines) Patch
M content/browser/devtools/devtools_http_handler_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/devtools_tracing_handler.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/browser/devtools/devtools_tracing_handler.cc View 2 chunks +11 lines, -2 lines 0 comments Download
M content/browser/devtools/render_view_devtools_agent_host.cc View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
yurys
6 years, 7 months ago (2014-05-19 06:17:47 UTC) #1
pfeldman
lgtm
6 years, 7 months ago (2014-05-19 06:19:47 UTC) #2
caseq
lgtm
6 years, 7 months ago (2014-05-19 06:28:55 UTC) #3
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 7 months ago (2014-05-19 06:35:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/295613002/1
6 years, 7 months ago (2014-05-19 06:35:17 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-19 08:34:23 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-19 09:28:05 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/154916)
6 years, 7 months ago (2014-05-19 09:28:06 UTC) #8
yurys
6 years, 7 months ago (2014-05-19 12:47:32 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 manually as r271368 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698