Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: third_party/WebKit/public/platform/WebMediaStreamTrack.h

Issue 2956063003: Add support for echoCancellation and deviceId to MediaStreamTrack.getSettings (Closed)
Patch Set: fix DCHECK Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/public/platform/WebMediaStreamSource.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/platform/WebMediaStreamTrack.h
diff --git a/third_party/WebKit/public/platform/WebMediaStreamTrack.h b/third_party/WebKit/public/platform/WebMediaStreamTrack.h
index 0921b7d4d8dcbce625eb71db8a4460145fa2c73d..f493d853b1b8c9c25185606048f868f4a1111015 100644
--- a/third_party/WebKit/public/platform/WebMediaStreamTrack.h
+++ b/third_party/WebKit/public/platform/WebMediaStreamTrack.h
@@ -49,6 +49,7 @@ class WebMediaStreamTrack {
bool HasHeight() const { return height >= 0; }
bool HasAspectRatio() const { return aspect_ratio >= 0.0; }
bool HasFacingMode() const { return facing_mode != FacingMode::kNone; }
+ bool HasEchoCancellationValue() const { return echo_cancellation >= 0; }
bool HasVideoKind() const { return !video_kind.IsNull(); }
bool HasFocalLengthX() const { return focal_length_x >= 0.0; }
bool HasFocalLengthY() const { return focal_length_y >= 0.0; }
@@ -62,6 +63,9 @@ class WebMediaStreamTrack {
double aspect_ratio = -1.0;
WebString device_id;
FacingMode facing_mode = FacingMode::kNone;
+ // |echo_cancellation| should be some form of Optional<bool> instead of int,
+ // but none is available for this file. Using -1 to indicate no value.
+ int echo_cancellation = -1;
// Media Capture Depth Stream Extensions.
WebString video_kind;
double focal_length_x = -1.0;
« no previous file with comments | « third_party/WebKit/public/platform/WebMediaStreamSource.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698