third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp - Issue 2956063003: Add support for echoCancellation and deviceId to MediaStreamTrack.getSettings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp

Issue 2956063003: Add support for echoCancellation and deviceId to MediaStreamTrack.getSettings (Closed)

Patch Set: fix DCHECK Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/mediastream/MediaStreamSource.h ('k') | third_party/WebKit/public/platform/WebMediaStreamSource.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp

diff --git a/third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp b/third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp

index 5cab26fbe1374d1ffc8d9e23c79f9dd7469bb517..7f5ab9cf6481259a63b95bbad3595ccf2c621494 100644

--- a/third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp

+++ b/third_party/WebKit/Source/platform/mediastream/MediaStreamSource.cpp

@@ -108,6 +108,9 @@ bool MediaStreamSource::RemoveAudioConsumer(

void MediaStreamSource::GetSettings(WebMediaStreamTrack::Settings& settings) {

settings.device_id = Id();

+ if (echo_cancellation_.has_value())

+ settings.echo_cancellation = *echo_cancellation_;

}

void MediaStreamSource::SetAudioFormat(size_t number_of_channels,