third_party/WebKit/Source/modules/mediastream/MediaTrackSettings.idl - Issue 2956063003: Add support for echoCancellation and deviceId to MediaStreamTrack.getSettings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediastream/MediaTrackSettings.idl

Issue 2956063003: Add support for echoCancellation and deviceId to MediaStreamTrack.getSettings (Closed)

Patch Set: fix DCHECK Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp ('k') | third_party/WebKit/Source/platform/exported/WebMediaStreamSource.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/mediastream/MediaTrackSettings.idl

diff --git a/third_party/WebKit/Source/modules/mediastream/MediaTrackSettings.idl b/third_party/WebKit/Source/modules/mediastream/MediaTrackSettings.idl

index 53e12bffc57ecbd1c124e8461e30c84fcdbcfd40..ac779fefb8f5c3deaf83a628e7d9f8ab0fd59e46 100644

--- a/third_party/WebKit/Source/modules/mediastream/MediaTrackSettings.idl

+++ b/third_party/WebKit/Source/modules/mediastream/MediaTrackSettings.idl

@@ -14,8 +14,7 @@ dictionary MediaTrackSettings {

// double volume;

// long sampleRate;

// long sampleSize;

- // echoCancellation is not implemented: crbug.com/682245

- // boolean echoCancellation;

+ boolean echoCancellation;

// latency and channelCount are not implemented.

// double latency;

// long channelCount;