Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(771)

Unified Diff: content/browser/renderer_host/media/media_devices_dispatcher_host.cc

Issue 2956063003: Add support for echoCancellation and deviceId to MediaStreamTrack.getSettings (Closed)
Patch Set: fix DCHECK Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/webrtc/webrtc_getusermedia_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/renderer_host/media/media_devices_dispatcher_host.cc
diff --git a/content/browser/renderer_host/media/media_devices_dispatcher_host.cc b/content/browser/renderer_host/media/media_devices_dispatcher_host.cc
index ece23f0c0965a3be466a6e792bc4344c93a182d3..4fcd2db996ca9dc0a25f118365a8b78bcd4823c8 100644
--- a/content/browser/renderer_host/media/media_devices_dispatcher_host.cc
+++ b/content/browser/renderer_host/media/media_devices_dispatcher_host.cc
@@ -10,6 +10,7 @@
#include <vector>
#include "base/bind_helpers.h"
+#include "base/command_line.h"
#include "base/memory/ptr_util.h"
#include "content/browser/bad_message.h"
#include "content/browser/media/media_devices_util.h"
@@ -22,6 +23,7 @@
#include "content/public/browser/render_frame_host.h"
#include "content/public/common/media_stream_request.h"
#include "media/audio/audio_system.h"
+#include "media/base/media_switches.h"
#include "media/base/video_facing.h"
#include "mojo/public/cpp/bindings/strong_binding.h"
#include "services/service_manager/public/cpp/interface_provider.h"
@@ -498,17 +500,21 @@ void MediaDevicesDispatcherHost::GotAudioInputEnumeration(
DCHECK_CURRENTLY_ON(BrowserThread::IO);
DCHECK_GT(pending_audio_input_capabilities_requests_.size(), 0U);
DCHECK(current_audio_input_capabilities_.empty());
+ DCHECK_EQ(num_pending_audio_input_parameters_, 0U);
for (const auto& device_info : enumeration[MEDIA_DEVICE_TYPE_AUDIO_INPUT]) {
::mojom::AudioInputDeviceCapabilities capabilities(
- device_info.device_id, media::AudioParameters());
+ device_info.device_id,
+ media::AudioParameters::UnavailableDeviceParams());
if (device_info.device_id == default_device_id)
current_audio_input_capabilities_.insert(
current_audio_input_capabilities_.begin(), std::move(capabilities));
else
current_audio_input_capabilities_.push_back(std::move(capabilities));
}
- // No devices, no need to read audio parameters.
- if (current_audio_input_capabilities_.empty()) {
+ // No devices or fake devices, no need to read audio parameters.
+ if (current_audio_input_capabilities_.empty() ||
+ base::CommandLine::ForCurrentProcess()->HasSwitch(
+ switches::kUseFakeDeviceForMediaStream)) {
FinalizeGetAudioInputCapabilities();
return;
}
@@ -531,9 +537,10 @@ void MediaDevicesDispatcherHost::GotAudioInputParameters(
DCHECK_GT(current_audio_input_capabilities_.size(), index);
DCHECK_GT(num_pending_audio_input_parameters_, 0U);
- current_audio_input_capabilities_[index].parameters =
- parameters.IsValid() ? parameters
- : media::AudioParameters::UnavailableDeviceParams();
+ if (parameters.IsValid())
+ current_audio_input_capabilities_[index].parameters = parameters;
+
+ DCHECK(current_audio_input_capabilities_[index].parameters.IsValid());
if (--num_pending_audio_input_parameters_ == 0U)
FinalizeGetAudioInputCapabilities();
}
@@ -541,7 +548,7 @@ void MediaDevicesDispatcherHost::GotAudioInputParameters(
void MediaDevicesDispatcherHost::FinalizeGetAudioInputCapabilities() {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
DCHECK_GT(pending_audio_input_capabilities_requests_.size(), 0U);
- DCHECK_EQ(0U, num_pending_audio_input_parameters_);
+ DCHECK_EQ(num_pending_audio_input_parameters_, 0U);
for (auto& request : pending_audio_input_capabilities_requests_) {
std::move(request.client_callback)
« no previous file with comments | « no previous file | content/browser/webrtc/webrtc_getusermedia_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698