third_party/WebKit/Source/modules/accessibility/AXSpinButton.h - Issue 2956053005: Keep track of fixed positioning in accessibility tree.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXSpinButton.h

Issue 2956053005: Keep track of fixed positioning in accessibility tree.

Patch Set: GetSimpleRelativeBounds, add failing test for fixed with transform Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/accessibility/AXSpinButton.h

diff --git a/third_party/WebKit/Source/modules/accessibility/AXSpinButton.h b/third_party/WebKit/Source/modules/accessibility/AXSpinButton.h

index 85fcad89f78040f4cdf25f2ee2feafd84aa8ce6a..c417293bb9e278e7ee45593d53eef6b959752af8 100644

--- a/third_party/WebKit/Source/modules/accessibility/AXSpinButton.h

+++ b/third_party/WebKit/Source/modules/accessibility/AXSpinButton.h

@@ -73,9 +73,9 @@ class AXSpinButtonPart final : public AXMockObject {

bool Press() override;

AccessibilityRole RoleValue() const override { return kButtonRole; }

bool IsSpinButtonPart() const override { return true; }

- void GetRelativeBounds(AXObject** out_container,

- FloatRect& out_bounds_in_container,

- SkMatrix44& out_container_transform) const override;

+ bool GetSimpleRelativeBounds(

+ AXObject** out_container,

+ FloatRect& out_bounds_in_container) const override;

};

DEFINE_AX_OBJECT_TYPE_CASTS(AXSpinButton, IsNativeSpinButton());