Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(649)

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp

Issue 2956053005: Keep track of fixed positioning in accessibility tree.
Patch Set: GetSimpleRelativeBounds, add failing test for fixed with transform Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp
diff --git a/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp b/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp
index 156fd55d739918a4460619516149fa7d3d802338..cf627c64b5900f57f2fbce0de38eb86797371f79 100644
--- a/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp
+++ b/third_party/WebKit/Source/modules/accessibility/AXMenuListOption.cpp
@@ -155,10 +155,10 @@ bool AXMenuListOption::ComputeAccessibilityIsIgnored(
return AccessibilityIsIgnoredByDefault(ignored_reasons);
}
-void AXMenuListOption::GetRelativeBounds(
- AXObject** out_container,
- FloatRect& out_bounds_in_container,
- SkMatrix44& out_container_transform) const {
+void AXMenuListOption::GetRelativeBounds(AXObject** out_container,
+ FloatRect& out_bounds_in_container,
+ SkMatrix44& out_container_transform,
+ bool& out_is_fixed_positioned) const {
*out_container = nullptr;
out_bounds_in_container = FloatRect();
out_container_transform.setIdentity();
@@ -173,7 +173,8 @@ void AXMenuListOption::GetRelativeBounds(
return;
DCHECK(grandparent->IsMenuList());
grandparent->GetRelativeBounds(out_container, out_bounds_in_container,
- out_container_transform);
+ out_container_transform,
+ out_is_fixed_positioned);
}
String AXMenuListOption::TextAlternative(bool recursive,

Powered by Google App Engine
This is Rietveld 408576698