Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp

Issue 2956053005: Keep track of fixed positioning in accessibility tree.
Patch Set: GetSimpleRelativeBounds, add failing test for fixed with transform Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp
diff --git a/third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp b/third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp
index 068a1d7b27b3a6b65f2df4b1b5f126f5ef02c08c..03806892ee1ad2db54fb0e81df765d154d0e663f 100644
--- a/third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp
+++ b/third_party/WebKit/Source/modules/accessibility/AXInlineTextBox.cpp
@@ -56,17 +56,15 @@ void AXInlineTextBox::Detach() {
inline_text_box_ = nullptr;
}
-void AXInlineTextBox::GetRelativeBounds(
+bool AXInlineTextBox::GetSimpleRelativeBounds(
AXObject** out_container,
- FloatRect& out_bounds_in_container,
- SkMatrix44& out_container_transform) const {
+ FloatRect& out_bounds_in_container) const {
*out_container = nullptr;
out_bounds_in_container = FloatRect();
- out_container_transform.setIdentity();
if (!inline_text_box_ || !ParentObject() ||
!ParentObject()->GetLayoutObject())
- return;
+ return false;
*out_container = ParentObject();
out_bounds_in_container = FloatRect(inline_text_box_->LocalBounds());
@@ -77,6 +75,7 @@ void AXInlineTextBox::GetRelativeBounds(
FloatRect parent_bounding_box =
parent_layout_object->LocalBoundingBoxRectForAccessibility();
out_bounds_in_container.MoveBy(-parent_bounding_box.Location());
+ return true;
}
bool AXInlineTextBox::ComputeAccessibilityIsIgnored(

Powered by Google App Engine
This is Rietveld 408576698