Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(934)

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXImageMapLink.cpp

Issue 2956053005: Keep track of fixed positioning in accessibility tree.
Patch Set: GetSimpleRelativeBounds, add failing test for fixed with transform Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/accessibility/AXImageMapLink.cpp
diff --git a/third_party/WebKit/Source/modules/accessibility/AXImageMapLink.cpp b/third_party/WebKit/Source/modules/accessibility/AXImageMapLink.cpp
index b8bca55ac8655527c38485892b6eb95236cead4a..d15f95b375bde026a0260e7b2772f2f7c5774bd9 100644
--- a/third_party/WebKit/Source/modules/accessibility/AXImageMapLink.cpp
+++ b/third_party/WebKit/Source/modules/accessibility/AXImageMapLink.cpp
@@ -97,18 +97,16 @@ KURL AXImageMapLink::Url() const {
return AreaElement()->Href();
}
-void AXImageMapLink::GetRelativeBounds(
+bool AXImageMapLink::GetSimpleRelativeBounds(
AXObject** out_container,
- FloatRect& out_bounds_in_container,
- SkMatrix44& out_container_transform) const {
+ FloatRect& out_bounds_in_container) const {
*out_container = nullptr;
out_bounds_in_container = FloatRect();
- out_container_transform.setIdentity();
HTMLAreaElement* area = AreaElement();
HTMLMapElement* map = MapElement();
if (!area || !map)
- return;
+ return false;
LayoutObject* layout_object;
if (parent_ && parent_->IsAXLayoutObject())
@@ -117,10 +115,11 @@ void AXImageMapLink::GetRelativeBounds(
layout_object = map->GetLayoutObject();
if (!layout_object)
- return;
+ return false;
out_bounds_in_container = area->GetPath(layout_object).BoundingRect();
*out_container = AxObjectCache().GetOrCreate(layout_object);
+ return true;
}
DEFINE_TRACE(AXImageMapLink) {

Powered by Google App Engine
This is Rietveld 408576698