Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Issue 295603004: [Cast] Aggressively send sender reports until first receiver report is received. (Closed)

Created:
6 years, 7 months ago by miu
Modified:
6 years, 7 months ago
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, pwestin+watch_google.com, feature-media-reviews_chromium.org, miu+watch_chromium.org, hubbe+watch_chromium.org, mikhal+watch_chromium.org
Visibility:
Public.

Description

[Cast] Aggressively send sender reports until first receiver report is received. Identical logic change in both AudioSender and VideoSender: Send a sender report just before each frame, up to the first 100 frames. Then, they are sent at ~1 second intervals thereafter. However, if a receiver report shows up, we halt the aggressive report sending immediately since we know the data dependency (receiver side) has been satisfied. Also, misc clean-ups: 1. RtpTimestampHelper threw away significant precision in its calculations (was truncating to millis). 2. Unit tests were using EXPECT with args in the wrong order (per gtest requirements). 3. Got rid of useless LocalRtcpXXXXXSenderFeedback class. BUG=371482 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272732

Patch Set 1 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -103 lines) Patch
M media/cast/audio_sender/audio_sender.h View 2 chunks +6 lines, -8 lines 0 comments Download
M media/cast/audio_sender/audio_sender.cc View 6 chunks +51 lines, -36 lines 0 comments Download
M media/cast/audio_sender/audio_sender_unittest.cc View 4 chunks +11 lines, -6 lines 0 comments Download
M media/cast/rtcp/rtcp.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/cast/rtp_timestamp_helper.cc View 1 chunk +4 lines, -3 lines 2 comments Download
M media/cast/video_sender/video_sender.h View 5 chunks +6 lines, -5 lines 0 comments Download
M media/cast/video_sender/video_sender.cc View 7 chunks +39 lines, -27 lines 0 comments Download
M media/cast/video_sender/video_sender_unittest.cc View 7 chunks +22 lines, -18 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
miu
hubbe: PTAL. https://codereview.chromium.org/295603004/diff/20001/media/cast/rtp_timestamp_helper.cc File media/cast/rtp_timestamp_helper.cc (left): https://codereview.chromium.org/295603004/diff/20001/media/cast/rtp_timestamp_helper.cc#oldcode23 media/cast/rtp_timestamp_helper.cc:23: *rtp_timestamp = last_rtp_timestamp_ + elapsed_time.InMilliseconds() * Not ...
6 years, 7 months ago (2014-05-23 22:41:28 UTC) #1
hubbe
https://codereview.chromium.org/295603004/diff/20001/media/cast/rtp_timestamp_helper.cc File media/cast/rtp_timestamp_helper.cc (right): https://codereview.chromium.org/295603004/diff/20001/media/cast/rtp_timestamp_helper.cc#newcode24 media/cast/rtp_timestamp_helper.cc:24: elapsed_time * frequency_ / base::TimeDelta::FromSeconds(1); I think this will ...
6 years, 7 months ago (2014-05-23 22:47:33 UTC) #2
hubbe
lgtm
6 years, 7 months ago (2014-05-23 22:51:23 UTC) #3
miu
The CQ bit was checked by miu@chromium.org
6 years, 7 months ago (2014-05-23 22:51:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/miu@chromium.org/295603004/20001
6 years, 7 months ago (2014-05-23 22:53:23 UTC) #5
Alpha Left Google
LGTM to me too.
6 years, 7 months ago (2014-05-23 23:00:06 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-24 13:05:27 UTC) #7
Message was sent while issue was closed.
Change committed as 272732

Powered by Google App Engine
This is Rietveld 408576698