Use toWebTextAreaElement in GetTextWebTextAreaElement

components/autofill/content/renderer/page_click_tracker.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/content/renderer/page_click_tracker.h"
 
 #include "components/autofill/content/renderer/form_autofill_util.h"
 #include "components/autofill/content/renderer/page_click_listener.h"
 #include "content/public/renderer/render_view.h"
 #include "third_party/WebKit/public/platform/WebString.h"
@@ skipping 30 matching lines @@
     return WebInputElement();
   const WebInputElement* input = blink::toWebInputElement(&element);
   if (!autofill::IsTextInput(input))
     return WebInputElement();
   return *input;
 }
 
 // Casts |node| to a WebTextAreaElement.
 // Returns an empty (isNull()) WebTextAreaElement if |node| is not a
 // textarea field.
 const WebTextAreaElement GetTextWebTextAreaElement(const WebNode& node) {

[Ilya Sherman, 2014/05/19 08:41:21]

nit: While you're here, would you mind updating the function name to drop the
redundant "Text", i.e. "GetWebTextAreaElement()"?

   if (!node.isElementNode())
     return WebTextAreaElement();
   const WebElement element = node.toConst<WebElement>();
-  if (!element.hasTagName("textarea"))
+  const WebTextAreaElement* textarea_element =
+      blink::toWebTextAreaElement(&element);
+  if (!textarea_element)
     return WebTextAreaElement();
-  return element.toConst<WebTextAreaElement>();
+  return *textarea_element;
 }
 
 // Checks to see if a text field was the previously selected node and is now
 // losing its focus.
 bool DidSelectedTextFieldLoseFocus(const WebNode& newly_clicked_node) {
   blink::WebElement focused_element =
     newly_clicked_node.document().focusedElement();
 
   if (focused_element.isNull() ||
       (GetTextWebInputElement(focused_element).isNull() &&
@@ skipping 91 matching lines @@
   was_focused_ = (node.document().focusedElement() == last_node_clicked_);
 }
 
 void PageClickTracker::HandleTextFieldMaybeLosingFocus(
     const WebNode& newly_clicked_node) {
   if (DidSelectedTextFieldLoseFocus(newly_clicked_node))
     listener_->FormControlElementLostFocus();
 }
 
 }  // namespace autofill