Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Side by Side Diff: third_party/WebKit/Source/core/input/EventHandler.cpp

Issue 2956023004: Add a flag to update hover effect when a layout is changed (Closed)
Patch Set: hover layout Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights
3 * reserved. 3 * reserved.
4 * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org) 4 * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org)
5 * Copyright (C) 2012 Digia Plc. and/or its subsidiary(-ies) 5 * Copyright (C) 2012 Digia Plc. and/or its subsidiary(-ies)
6 * 6 *
7 * Redistribution and use in source and binary forms, with or without 7 * Redistribution and use in source and binary forms, with or without
8 * modification, are permitted provided that the following conditions 8 * modification, are permitted provided that the following conditions
9 * are met: 9 * are met:
10 * 1. Redistributions of source code must retain the above copyright 10 * 1. Redistributions of source code must retain the above copyright
(...skipping 1866 matching lines...) Expand 10 before | Expand all | Expand 10 after
1877 !mouse_event_manager_->IsMousePositionUnknown()) 1877 !mouse_event_manager_->IsMousePositionUnknown())
1878 hover_timer_.StartOneShot(0, BLINK_FROM_HERE); 1878 hover_timer_.StartOneShot(0, BLINK_FROM_HERE);
1879 } 1879 }
1880 1880
1881 void EventHandler::ScheduleCursorUpdate() { 1881 void EventHandler::ScheduleCursorUpdate() {
1882 // We only want one timer for the page, rather than each frame having it's own 1882 // We only want one timer for the page, rather than each frame having it's own
1883 // timer competing which eachother (since there's only one mouse cursor). 1883 // timer competing which eachother (since there's only one mouse cursor).
1884 DCHECK_EQ(frame_, &frame_->LocalFrameRoot()); 1884 DCHECK_EQ(frame_, &frame_->LocalFrameRoot());
1885 1885
1886 // TODO(https://crbug.com/668758): Use a normal BeginFrame update for this. 1886 // TODO(https://crbug.com/668758): Use a normal BeginFrame update for this.
1887 if (!cursor_update_timer_.IsActive()) 1887 if (!cursor_update_timer_.IsActive()) {
dtapuska 2017/06/28 19:15:17 No need to add braces here; code isn't changed.
lanwei 2017/07/04 18:37:15 Done.
1888 cursor_update_timer_.StartOneShot(kCursorUpdateInterval, BLINK_FROM_HERE); 1888 cursor_update_timer_.StartOneShot(kCursorUpdateInterval, BLINK_FROM_HERE);
1889 }
1889 } 1890 }
1890 1891
1891 bool EventHandler::CursorUpdatePending() { 1892 bool EventHandler::CursorUpdatePending() {
1892 return cursor_update_timer_.IsActive(); 1893 return cursor_update_timer_.IsActive();
1893 } 1894 }
1894 1895
1895 void EventHandler::DispatchFakeMouseMoveEventSoon() { 1896 bool EventHandler::FakeMouseMovePending() {
1896 mouse_event_manager_->DispatchFakeMouseMoveEventSoon(); 1897 return mouse_event_manager_->FakeMouseMovePending();
1898 }
1899
1900 void EventHandler::DispatchFakeMouseMoveEventSoon(
1901 DispatchInterval dispatch_interval) {
1902 mouse_event_manager_->DispatchFakeMouseMoveEventSoon(dispatch_interval);
1897 } 1903 }
1898 1904
1899 void EventHandler::DispatchFakeMouseMoveEventSoonInQuad(const FloatQuad& quad) { 1905 void EventHandler::DispatchFakeMouseMoveEventSoonInQuad(const FloatQuad& quad) {
1900 mouse_event_manager_->DispatchFakeMouseMoveEventSoonInQuad(quad); 1906 mouse_event_manager_->DispatchFakeMouseMoveEventSoonInQuad(quad);
1901 } 1907 }
1902 1908
1903 void EventHandler::SetResizingFrameSet(HTMLFrameSetElement* frame_set) { 1909 void EventHandler::SetResizingFrameSet(HTMLFrameSetElement* frame_set) {
1904 frame_set_being_resized_ = frame_set; 1910 frame_set_being_resized_ = frame_set;
1905 } 1911 }
1906 1912
(...skipping 185 matching lines...) Expand 10 before | Expand all | Expand 10 after
2092 MouseEventWithHitTestResults& mev, 2098 MouseEventWithHitTestResults& mev,
2093 LocalFrame* subframe) { 2099 LocalFrame* subframe) {
2094 WebInputEventResult result = 2100 WebInputEventResult result =
2095 subframe->GetEventHandler().HandleMouseReleaseEvent(mev.Event()); 2101 subframe->GetEventHandler().HandleMouseReleaseEvent(mev.Event());
2096 if (result != WebInputEventResult::kNotHandled) 2102 if (result != WebInputEventResult::kNotHandled)
2097 return result; 2103 return result;
2098 return WebInputEventResult::kHandledSystem; 2104 return WebInputEventResult::kHandledSystem;
2099 } 2105 }
2100 2106
2101 } // namespace blink 2107 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698