Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: net/url_request/url_request_context_builder.h

Issue 2956023003: Add enable_reporting to fix size regression in Cronet. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/url_request/url_request_context_builder.h
diff --git a/net/url_request/url_request_context_builder.h b/net/url_request/url_request_context_builder.h
index 2a520017cae85457ef517e3a0daf942eba8e52dc..fcb4b1e753cba445a0b78333c58b559dd896393b 100644
--- a/net/url_request/url_request_context_builder.h
+++ b/net/url_request/url_request_context_builder.h
@@ -304,10 +304,10 @@ class NET_EXPORT URLRequestContextBuilder {
void SetCertVerifier(std::unique_ptr<CertVerifier> cert_verifier);
- // Sets the reporting policy of the created request context. If not set, or
- // set to nullptr, reporting is disabled.
+#if BUILDFLAG(ENABLE_REPORTING)
void set_reporting_policy(
std::unique_ptr<net::ReportingPolicy> reporting_policy);
+#endif // BUILDFLAG(ENABLE_REPORTING)
void SetInterceptors(std::vector<std::unique_ptr<URLRequestInterceptor>>
url_request_interceptors);
@@ -398,7 +398,9 @@ class NET_EXPORT URLRequestContextBuilder {
std::unique_ptr<HttpAuthHandlerFactory> http_auth_handler_factory_;
std::unique_ptr<CertVerifier> cert_verifier_;
std::unique_ptr<CTVerifier> ct_verifier_;
+#if BUILDFLAG(ENABLE_REPORTING)
std::unique_ptr<net::ReportingPolicy> reporting_policy_;
+#endif // BUILDFLAG(ENABLE_REPORTING)
std::vector<std::unique_ptr<URLRequestInterceptor>> url_request_interceptors_;
std::unique_ptr<HttpServerProperties> http_server_properties_;
std::map<std::string, std::unique_ptr<URLRequestJobFactory::ProtocolHandler>>

Powered by Google App Engine
This is Rietveld 408576698