Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: ios/chrome/browser/experimental_flags.mm

Issue 2956013002: [ios] Workaround error affecting 3rd party keyboards and omnibox. (Closed)
Patch Set: Update comment Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/experimental_flags.h ('k') | ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/experimental_flags.mm
diff --git a/ios/chrome/browser/experimental_flags.mm b/ios/chrome/browser/experimental_flags.mm
index 3880c9777d803cd8ece35311f600d206e23e1586..a84f60032b3c2dc3bbda2f2e30ac948a6b03b80e 100644
--- a/ios/chrome/browser/experimental_flags.mm
+++ b/ios/chrome/browser/experimental_flags.mm
@@ -44,6 +44,8 @@ NSString* const kSafariVCSignInDisabled = @"SafariVCSignInDisabled";
NSString* const kWhatsNewPromoStatus = @"WhatsNewPromoStatus";
const base::Feature kEnableSlimNavigationManager{
"EnableSlimNavigationManager", base::FEATURE_DISABLED_BY_DEFAULT};
+const base::Feature kEnableThirdPartyKeyboardWorkaround{
+ "EnableThirdPartyKeyboardWorkaround", base::FEATURE_ENABLED_BY_DEFAULT};
} // namespace
@@ -304,4 +306,18 @@ bool IsSlimNavigationManagerEnabled() {
return base::FeatureList::IsEnabled(kEnableSlimNavigationManager);
}
+bool IsThirdPartyKeyboardWorkaroundEnabled() {
+ // Check if the experimental flag is forced on or off.
+ base::CommandLine* command_line = base::CommandLine::ForCurrentProcess();
+ if (command_line->HasSwitch(switches::kEnableThirdPartyKeyboardWorkaround)) {
+ return true;
+ } else if (command_line->HasSwitch(
+ switches::kDisableThirdPartyKeyboardWorkaround)) {
+ return false;
+ }
+
+ // Check if the Finch experiment is turned on.
+ return base::FeatureList::IsEnabled(kEnableThirdPartyKeyboardWorkaround);
+}
+
} // namespace experimental_flags
« no previous file with comments | « ios/chrome/browser/experimental_flags.h ('k') | ios/chrome/browser/ui/omnibox/omnibox_text_field_ios.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698