Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Side by Side Diff: components/cronet/url_request_context_config_unittest.cc

Issue 2955973008: Disabled three flaky cronet tests. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/cronet/stale_host_resolver_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/cronet/url_request_context_config.h" 5 #include "components/cronet/url_request_context_config.h"
6 6
7 #include "base/memory/ptr_util.h" 7 #include "base/memory/ptr_util.h"
8 #include "base/message_loop/message_loop.h" 8 #include "base/message_loop/message_loop.h"
9 #include "base/values.h" 9 #include "base/values.h"
10 #include "net/cert/cert_verifier.h" 10 #include "net/cert/cert_verifier.h"
11 #include "net/http/http_network_session.h" 11 #include "net/http/http_network_session.h"
12 #include "net/log/net_log.h" 12 #include "net/log/net_log.h"
13 #include "net/log/net_log_with_source.h" 13 #include "net/log/net_log_with_source.h"
14 #include "net/proxy/proxy_config.h" 14 #include "net/proxy/proxy_config.h"
15 #include "net/proxy/proxy_config_service_fixed.h" 15 #include "net/proxy/proxy_config_service_fixed.h"
16 #include "net/url_request/url_request_context.h" 16 #include "net/url_request/url_request_context.h"
17 #include "net/url_request/url_request_context_builder.h" 17 #include "net/url_request/url_request_context_builder.h"
18 #include "testing/gtest/include/gtest/gtest.h" 18 #include "testing/gtest/include/gtest/gtest.h"
19 19
20 namespace cronet { 20 namespace cronet {
21 21
22 TEST(URLRequestContextConfigTest, TestExperimentalOptionParsing) { 22 // Test is flaky. See https://crbug.com/737326.
23 TEST(URLRequestContextConfigTest, DISABLED_TestExperimentalOptionParsing) {
23 URLRequestContextConfig config( 24 URLRequestContextConfig config(
24 // Enable QUIC. 25 // Enable QUIC.
25 true, 26 true,
26 // QUIC User Agent ID. 27 // QUIC User Agent ID.
27 "Default QUIC User Agent ID", 28 "Default QUIC User Agent ID",
28 // Enable SPDY. 29 // Enable SPDY.
29 true, 30 true,
30 // Enable SDCH. 31 // Enable SDCH.
31 false, 32 false,
32 // Enable Brotli. 33 // Enable Brotli.
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 104
104 // Check IPv6 is disabled when on wifi. 105 // Check IPv6 is disabled when on wifi.
105 EXPECT_TRUE(context->host_resolver()->GetNoIPv6OnWifi()); 106 EXPECT_TRUE(context->host_resolver()->GetNoIPv6OnWifi());
106 107
107 net::HostResolver::RequestInfo info(net::HostPortPair("abcde", 80)); 108 net::HostResolver::RequestInfo info(net::HostPortPair("abcde", 80));
108 net::AddressList addresses; 109 net::AddressList addresses;
109 EXPECT_EQ(net::OK, context->host_resolver()->ResolveFromCache( 110 EXPECT_EQ(net::OK, context->host_resolver()->ResolveFromCache(
110 info, &addresses, net::NetLogWithSource())); 111 info, &addresses, net::NetLogWithSource()));
111 } 112 }
112 113
113 TEST(URLRequestContextConfigTest, SetQuicConnectionMigrationOptions) { 114 // Test is flaky. See https://crbug.com/737326.
115 TEST(URLRequestContextConfigTest, DISABLED_SetQuicConnectionMigrationOptions) {
114 URLRequestContextConfig config( 116 URLRequestContextConfig config(
115 // Enable QUIC. 117 // Enable QUIC.
116 true, 118 true,
117 // QUIC User Agent ID. 119 // QUIC User Agent ID.
118 "Default QUIC User Agent ID", 120 "Default QUIC User Agent ID",
119 // Enable SPDY. 121 // Enable SPDY.
120 true, 122 true,
121 // Enable SDCH. 123 // Enable SDCH.
122 false, 124 false,
123 // Enable Brotli. 125 // Enable Brotli.
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 context->GetNetworkSessionParams(); 160 context->GetNetworkSessionParams();
159 161
160 EXPECT_FALSE(params->quic_close_sessions_on_ip_change); 162 EXPECT_FALSE(params->quic_close_sessions_on_ip_change);
161 EXPECT_TRUE(params->quic_migrate_sessions_on_network_change); 163 EXPECT_TRUE(params->quic_migrate_sessions_on_network_change);
162 EXPECT_TRUE(params->quic_migrate_sessions_early); 164 EXPECT_TRUE(params->quic_migrate_sessions_early);
163 } 165 }
164 166
165 // See stale_host_resolver_unittest.cc for test of StaleDNS options. 167 // See stale_host_resolver_unittest.cc for test of StaleDNS options.
166 168
167 } // namespace cronet 169 } // namespace cronet
OLDNEW
« no previous file with comments | « components/cronet/stale_host_resolver_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698