Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Side by Side Diff: components/cronet/stale_host_resolver_unittest.cc

Issue 2955973008: Disabled three flaky cronet tests. (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/cronet/url_request_context_config_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/cronet/stale_host_resolver.h" 5 #include "components/cronet/stale_host_resolver.h"
6 6
7 #include "base/callback_helpers.h" 7 #include "base/callback_helpers.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
10 #include "base/memory/ref_counted.h" 10 #include "base/memory/ref_counted.h"
(...skipping 423 matching lines...) Expand 10 before | Expand all | Expand 10 after
434 EXPECT_EQ(1u, resolve_addresses().size()) << i; 434 EXPECT_EQ(1u, resolve_addresses().size()) << i;
435 { 435 {
436 const char* expected = test_case.usable ? kCacheAddress : kNetworkAddress; 436 const char* expected = test_case.usable ? kCacheAddress : kNetworkAddress;
437 EXPECT_EQ(expected, resolve_addresses()[0].ToStringWithoutPort()) << i; 437 EXPECT_EQ(expected, resolve_addresses()[0].ToStringWithoutPort()) << i;
438 } 438 }
439 439
440 DestroyResolver(); 440 DestroyResolver();
441 } 441 }
442 } 442 }
443 443
444 TEST_F(StaleHostResolverTest, CreatedByContext) { 444 // Test is flaky. See https://crbug.com/737326.
445 TEST_F(StaleHostResolverTest, DISABLED_CreatedByContext) {
445 URLRequestContextConfig config( 446 URLRequestContextConfig config(
446 // Enable QUIC. 447 // Enable QUIC.
447 true, 448 true,
448 // QUIC User Agent ID. 449 // QUIC User Agent ID.
449 "Default QUIC User Agent ID", 450 "Default QUIC User Agent ID",
450 // Enable SPDY. 451 // Enable SPDY.
451 true, 452 true,
452 // Enable SDCH. 453 // Enable SDCH.
453 false, 454 false,
454 // Enable Brotli. 455 // Enable Brotli.
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
499 500
500 EXPECT_TRUE(resolve_complete()); 501 EXPECT_TRUE(resolve_complete());
501 EXPECT_EQ(net::OK, resolve_error()); 502 EXPECT_EQ(net::OK, resolve_error());
502 EXPECT_EQ(1u, resolve_addresses().size()); 503 EXPECT_EQ(1u, resolve_addresses().size());
503 EXPECT_EQ(kCacheAddress, resolve_addresses()[0].ToStringWithoutPort()); 504 EXPECT_EQ(kCacheAddress, resolve_addresses()[0].ToStringWithoutPort());
504 } 505 }
505 506
506 } // namespace 507 } // namespace
507 508
508 } // namespace cronet 509 } // namespace cronet
OLDNEW
« no previous file with comments | « no previous file | components/cronet/url_request_context_config_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698