Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: ui/views/bubble/bubble_frame_view.h

Issue 2955963002: Update Chrome Upstream flow to reflect new UI mocks (Closed)
Patch Set: Actioning first round of tapted/msw code review comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/bubble/bubble_frame_view.h
diff --git a/ui/views/bubble/bubble_frame_view.h b/ui/views/bubble/bubble_frame_view.h
index 4f4d94647a9d20d963fecd7794bb06b640751441..52b952edd1b1f98b65103dac832f47d4bdb8c7db 100644
--- a/ui/views/bubble/bubble_frame_view.h
+++ b/ui/views/bubble/bubble_frame_view.h
@@ -96,8 +96,12 @@ class VIEWS_EXPORT BubbleFrameView : public NonClientFrameView,
gfx::Rect GetCloseButtonMirroredBounds() const;
private:
+ class FootnoteContainerView;
FRIEND_TEST_ALL_PREFIXES(BubbleFrameViewTest, GetBoundsForClientView);
FRIEND_TEST_ALL_PREFIXES(BubbleFrameViewTest, RemoveFootnoteView);
+ FRIEND_TEST_ALL_PREFIXES(
+ BubbleFrameViewTest,
+ FootnoteContainerViewShouldMatchVisibilityOfFirstChild);
FRIEND_TEST_ALL_PREFIXES(BubbleDelegateTest, CloseReasons);
FRIEND_TEST_ALL_PREFIXES(BubbleDialogDelegateTest, CloseMethods);
@@ -130,7 +134,7 @@ class VIEWS_EXPORT BubbleFrameView : public NonClientFrameView,
Button* close_;
// A view to contain the footnote view, if it exists.
- View* footnote_container_;
+ FootnoteContainerView* footnote_container_;
// Whether the close button was clicked.
bool close_button_clicked_;

Powered by Google App Engine
This is Rietveld 408576698