Update Chrome Upstream flow to reflect new UI mocks

chrome/browser/ui/views/autofill/save_card_bubble_views.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/autofill/save_card_bubble_views.h"
 
 #include <stddef.h>
 #include <memory>
 
 #include "base/strings/utf_string_conversions.h"
@@ skipping 45 matching lines @@
                                          SaveCardBubbleController* controller)
     : LocationBarBubbleDelegateView(anchor_view, web_contents),
       controller_(controller) {
   DCHECK(controller);
   views::BubbleDialogDelegateView::CreateBubble(this);
   chrome::RecordDialogCreation(chrome::DialogIdentifier::SAVE_CARD);
 }
 
 SaveCardBubbleViews::~SaveCardBubbleViews() {}
 
+SaveCardBubbleViews::CurrentFlowStep SaveCardBubbleViews::GetCurrentFlowStep()

[msw, 2017/06/29 20:10:25]

nit: reorder this (and dtor) to match decl (just before CreateMainContentView)

[Jared Saul, 2017/07/05 19:36:50]

Thanks, nice catch.  Also reordered IsDialogButtonEnabled and ContentsChanged to
match as well.

+    const {
+  // No legal messages means this is not upload save.
+  if (controller_->GetLegalMessageLines().empty())
+    return LOCAL_SAVE_ONLY_STEP;
+  // If we're not requesting CVC, this is the only step on the upload path.
+  if (!controller_->ShouldRequestCvcFromUser())
+    return UPLOAD_SAVE_ONLY_STEP;
+  // Must be on the CVC fix flow on the upload path.
+  if (view_stack_->size() == 1)
+    return UPLOAD_SAVE_CVC_FIX_FLOW_STEP_1_OFFER_UPLOAD;
+  if (view_stack_->size() == 2)
+    return UPLOAD_SAVE_CVC_FIX_FLOW_STEP_2_REQUEST_CVC;
+  // CVC fix flow should never have more than 3 views on the stack.
+  NOTREACHED();
+  return UNKNOWN_STEP;
+}
+
 void SaveCardBubbleViews::Show(DisplayReason reason) {
   ShowForReason(reason);
 }
 
 void SaveCardBubbleViews::Hide() {
   controller_ = nullptr;
   CloseBubble();
 }
 
 views::View* SaveCardBubbleViews::CreateExtraView() {
+  if (GetCurrentFlowStep() != LOCAL_SAVE_ONLY_STEP)
+    return nullptr;
+  // Learn More link is only shown on local save bubble.
   DCHECK(!learn_more_link_);
   learn_more_link_ = new views::Link(l10n_util::GetStringUTF16(IDS_LEARN_MORE));
   learn_more_link_->SetUnderline(false);
   learn_more_link_->set_listener(this);
   return learn_more_link_;
 }
 
+int SaveCardBubbleViews::GetDialogButtons() const {

[msw, 2017/06/29 20:10:25]

nit: reorder to match decl (above CreateExtraView)

[Jared Saul, 2017/07/05 19:36:50]

Done.

+  if (GetCurrentFlowStep() == LOCAL_SAVE_ONLY_STEP)
+    return ui::DIALOG_BUTTON_OK | ui::DIALOG_BUTTON_CANCEL;
+  // For upload save, don't show the "No thanks" cancel option; use the
+  // top-right [X] close button for that.
+  return ui::DIALOG_BUTTON_OK;
+}
+
 views::View* SaveCardBubbleViews::CreateFootnoteView() {
   if (controller_->GetLegalMessageLines().empty())
     return nullptr;
 
   // Use BoxLayout to provide insets around the label.
-  View* view = new View();
-  view->SetLayoutManager(new views::BoxLayout(views::BoxLayout::kVertical));
+  footnote_view_ = new View();
+  footnote_view_->SetLayoutManager(
+      new views::BoxLayout(views::BoxLayout::kVertical));
 
   // Add a StyledLabel for each line of the legal message.
   for (const LegalMessageLine& line : controller_->GetLegalMessageLines())

[msw, 2017/06/29 20:10:24]

nit: add curly braces for two-line body

[Jared Saul, 2017/07/05 19:36:50]

Done.

-    view->AddChildView(CreateLegalMessageLineLabel(line, this).release());
+    footnote_view_->AddChildView(
+        CreateLegalMessageLineLabel(line, this).release());
 
-  return view;
+  // If on the first step of the 2-step upload flow, hide the footer area until
+  // it's time to actually accept the dialog and ToS.
+  if (GetCurrentFlowStep() == UPLOAD_SAVE_CVC_FIX_FLOW_STEP_1_OFFER_UPLOAD)
+    footnote_view_->SetVisible(false);
+
+  return footnote_view_;
 }
 
 bool SaveCardBubbleViews::Accept() {
   // The main content ViewStack for local save and happy-path upload save should
   // only ever have 1 View on it. Upload save can have a second View if CVC
   // needs to be requested. Assert that the ViewStack has no more than 2 Views
   // and that if it *does* have 2, it's because CVC is being requested.
   DCHECK_LE(view_stack_->size(), 2U);
   DCHECK(view_stack_->size() == 1 || controller_->ShouldRequestCvcFromUser());
-  if (controller_->ShouldRequestCvcFromUser() && view_stack_->size() == 1) {
+  if (GetCurrentFlowStep() == UPLOAD_SAVE_CVC_FIX_FLOW_STEP_1_OFFER_UPLOAD) {
     // If user accepted upload but more info is needed, push the next view onto
-    // the stack.
+    // the stack and update the bubble.
+    DCHECK(controller_);
+    controller_->SetShowUploadConfirmTitle(true);
+    GetWidget()->UpdateWindowTitle();
     view_stack_->Push(CreateRequestCvcView(), /*animate=*/true);
     // Disable the Save button until a valid CVC is entered:
     GetDialogClientView()->UpdateDialogButtons();
+    // Make the legal messaging footer appear:
+    DCHECK(footnote_view_);
+    footnote_view_->SetVisible(true);
     // Resize the bubble if it's grown larger:
     SizeToContents();
     return false;
   }
   // Otherwise, close the bubble as normal.
   if (controller_)
     controller_->OnSaveButton(cvc_textfield_ ? cvc_textfield_->text()
                                              : base::string16());
   return true;
 }
 
 bool SaveCardBubbleViews::Cancel() {
   if (controller_)
     controller_->OnCancelButton();
   return true;
 }
 
 bool SaveCardBubbleViews::Close() {
   // Cancel is logged as a different user action than closing, so override
   // Close() to prevent the superclass' implementation from calling Cancel().
   // Return true to indicate that the bubble can be closed.
   return true;
 }
 
 base::string16 SaveCardBubbleViews::GetDialogButtonLabel(
     ui::DialogButton button) const {
-  return l10n_util::GetStringUTF16(button == ui::DIALOG_BUTTON_OK
-                                       ? IDS_AUTOFILL_SAVE_CARD_PROMPT_ACCEPT
-                                       : IDS_NO_THANKS);
+  switch (GetCurrentFlowStep()) {
+    // Local save has two buttons:
+    case LOCAL_SAVE_ONLY_STEP:
+      return l10n_util::GetStringUTF16(
+          button == ui::DIALOG_BUTTON_OK ? IDS_AUTOFILL_SAVE_CARD_PROMPT_ACCEPT
+                                         : IDS_NO_THANKS);
+    // Upload save has one button but it can say three different things:
+    case UPLOAD_SAVE_ONLY_STEP:
+      DCHECK(button == ui::DIALOG_BUTTON_OK);
+      return l10n_util::GetStringUTF16(IDS_AUTOFILL_SAVE_CARD_PROMPT_ACCEPT);
+    case UPLOAD_SAVE_CVC_FIX_FLOW_STEP_1_OFFER_UPLOAD:
+      DCHECK(button == ui::DIALOG_BUTTON_OK);
+      return l10n_util::GetStringUTF16(IDS_AUTOFILL_SAVE_CARD_PROMPT_NEXT);
+    case UPLOAD_SAVE_CVC_FIX_FLOW_STEP_2_REQUEST_CVC:
+      DCHECK(button == ui::DIALOG_BUTTON_OK);
+      return l10n_util::GetStringUTF16(IDS_AUTOFILL_SAVE_CARD_PROMPT_CONFIRM);
+    default:
+      NOTREACHED();
+      return base::string16();
+  }
 }
 
 gfx::Size SaveCardBubbleViews::CalculatePreferredSize() const {
   return gfx::Size(kBubbleWidth, GetHeightForWidth(kBubbleWidth));
 }
 
+bool SaveCardBubbleViews::ShouldShowCloseButton() const {
+  // Local save should have a [No thanks] button, but Upload save should surface

[msw, 2017/06/29 20:10:25]

nit: Use a consistent "No thanks" / [No thanks] comment style.

[Jared Saul, 2017/07/05 19:36:50]

Done; thanks.

+  // the top-right [X] close button instead.
+  return GetCurrentFlowStep() != LOCAL_SAVE_ONLY_STEP;
+}
+
 base::string16 SaveCardBubbleViews::GetWindowTitle() const {
   return controller_ ? controller_->GetWindowTitle() : base::string16();
 }
 
 void SaveCardBubbleViews::WindowClosing() {
   if (controller_)
     controller_->OnBubbleClosed();
 }
 
 void SaveCardBubbleViews::LinkClicked(views::Link* source, int event_flags) {
@@ skipping 30 matching lines @@
 
 // Create view containing everything except for the footnote.
 std::unique_ptr<views::View> SaveCardBubbleViews::CreateMainContentView() {
   auto view = base::MakeUnique<views::View>();
   ChromeLayoutProvider* provider = ChromeLayoutProvider::Get();
 
   view->SetLayoutManager(new views::BoxLayout(
       views::BoxLayout::kVertical, gfx::Insets(),
       provider->GetDistanceMetric(views::DISTANCE_UNRELATED_CONTROL_VERTICAL)));
 
+  // If applicable, add the upload explanation label.
+  base::string16 explanation = controller_->GetExplanatoryMessage();
+  if (!explanation.empty()) {
+    views::Label* explanation_label = new views::Label(explanation);
+    explanation_label->SetMultiLine(true);
+    explanation_label->SetHorizontalAlignment(gfx::ALIGN_LEFT);
+    view->AddChildView(explanation_label);
+  }
+
   // Add the card type icon, last four digits and expiration date.
   views::View* description_view = new views::View();
   description_view->SetLayoutManager(new views::BoxLayout(
       views::BoxLayout::kHorizontal, gfx::Insets(),
       provider->GetDistanceMetric(views::DISTANCE_RELATED_BUTTON_HORIZONTAL)));
   view->AddChildView(description_view);
 
   const CreditCard& card = controller_->GetCard();
   views::ImageView* card_type_icon = new views::ImageView();
   card_type_icon->SetImage(
       ResourceBundle::GetSharedInstance()
           .GetImageNamed(CreditCard::IconResourceId(card.network()))
           .AsImageSkia());
   card_type_icon->SetTooltipText(card.NetworkForDisplay());
   card_type_icon->SetBorder(
       views::CreateSolidBorder(1, SkColorSetA(SK_ColorBLACK, 10)));
   description_view->AddChildView(card_type_icon);
 
-  description_view->AddChildView(new views::Label(
-      base::string16(kMidlineEllipsis) + card.LastFourDigits()));
   description_view->AddChildView(
-      new views::Label(card.AbbreviatedExpirationDateForDisplay()));
-
-  // Optionally add label that will contain an explanation for upload.
-  base::string16 explanation = controller_->GetExplanatoryMessage();
-  if (!explanation.empty()) {
-    views::Label* explanation_label = new views::Label(explanation);
-    explanation_label->SetMultiLine(true);
-    explanation_label->SetHorizontalAlignment(gfx::ALIGN_LEFT);
-    view->AddChildView(explanation_label);
-  }
+      new views::Label(card.NetworkAndLastFourDigits()));
 
   return view;
 }
 
 std::unique_ptr<views::View> SaveCardBubbleViews::CreateRequestCvcView() {
   auto request_cvc_view = base::MakeUnique<views::View>();
+  ChromeLayoutProvider* provider = ChromeLayoutProvider::Get();
+
+  request_cvc_view->SetLayoutManager(new views::BoxLayout(
+      views::BoxLayout::kVertical, gfx::Insets(),
+      provider->GetDistanceMetric(views::DISTANCE_UNRELATED_CONTROL_VERTICAL)));
   request_cvc_view->SetBackground(views::CreateThemedSolidBackground(
       request_cvc_view.get(), ui::NativeTheme::kColorId_BubbleBackground));
-  views::BoxLayout* layout =
-      new views::BoxLayout(views::BoxLayout::kHorizontal, gfx::Insets(),
-                           ChromeLayoutProvider::Get()->GetDistanceMetric(
-                               views::DISTANCE_RELATED_BUTTON_HORIZONTAL));
+
+  views::Label* explanation_label = new views::Label(l10n_util::GetStringUTF16(
+      IDS_AUTOFILL_SAVE_CARD_PROMPT_ENTER_CVC_EXPLANATION));
+  explanation_label->SetMultiLine(true);
+  explanation_label->SetHorizontalAlignment(gfx::ALIGN_LEFT);
+  request_cvc_view->AddChildView(explanation_label);
+
+  views::View* cvc_entry_view = new views::View();
+  views::BoxLayout* layout = new views::BoxLayout(
+      views::BoxLayout::kHorizontal, gfx::Insets(),
+      provider->GetDistanceMetric(views::DISTANCE_RELATED_BUTTON_HORIZONTAL));
   layout->set_cross_axis_alignment(
       views::BoxLayout::CROSS_AXIS_ALIGNMENT_CENTER);
-  request_cvc_view->SetLayoutManager(layout);
+  cvc_entry_view->SetLayoutManager(layout);
 
   DCHECK(!cvc_textfield_);
   cvc_textfield_ = CreateCvcTextfield();
   cvc_textfield_->set_controller(this);
-  request_cvc_view->AddChildView(cvc_textfield_);
+  cvc_entry_view->AddChildView(cvc_textfield_);
 
   views::ImageView* cvc_image = new views::ImageView();
   ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
   cvc_image->SetImage(
       rb.GetImageSkiaNamed(controller_->GetCvcImageResourceId()));
-  request_cvc_view->AddChildView(cvc_image);
+  cvc_entry_view->AddChildView(cvc_image);
 
-  request_cvc_view->AddChildView(new views::Label(
-      l10n_util::GetStringUTF16(IDS_AUTOFILL_SAVE_CARD_PROMPT_ENTER_CVC)));
-
+  request_cvc_view->AddChildView(cvc_entry_view);
   return request_cvc_view;
 }
 
 bool SaveCardBubbleViews::IsDialogButtonEnabled(ui::DialogButton button) const {
   if (button == ui::DIALOG_BUTTON_CANCEL)
     return true;
 
   DCHECK_EQ(ui::DIALOG_BUTTON_OK, button);
   return !cvc_textfield_ ||
          controller_->InputCvcIsValid(cvc_textfield_->text());
 }
 
 void SaveCardBubbleViews::ContentsChanged(views::Textfield* sender,
                                           const base::string16& new_contents) {
   DCHECK_EQ(cvc_textfield_, sender);
   GetDialogClientView()->UpdateDialogButtons();
 }
 
 void SaveCardBubbleViews::Init() {
   SetLayoutManager(new views::BoxLayout(views::BoxLayout::kVertical));
   view_stack_ = new ViewStack();
   view_stack_->SetBackground(views::CreateThemedSolidBackground(
       view_stack_, ui::NativeTheme::kColorId_BubbleBackground));
   view_stack_->Push(CreateMainContentView(), /*animate=*/false);
   AddChildView(view_stack_);
 }
 
 }  // namespace autofill