Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2955963002: Update Chrome Upstream flow to reflect new UI mocks (Closed)
Patch Set: Put changes behind AutofillUpstreamShowNewUi flag Created 3 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/flag_descriptions.h » ('j') | chrome/browser/flag_descriptions.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 2858 matching lines...) Expand 10 before | Expand all | Expand 10 after
2869 autofill::kAutofillCreditCardLastUsedDateDisplay, 2869 autofill::kAutofillCreditCardLastUsedDateDisplay,
2870 kAutofillCreditCardLastUsedDateFeatureVariations, 2870 kAutofillCreditCardLastUsedDateFeatureVariations,
2871 // Must be AutofillCreditCardDropdownVariations to prevent DCHECK crash 2871 // Must be AutofillCreditCardDropdownVariations to prevent DCHECK crash
2872 // when the flag is manually enabled in a local build. 2872 // when the flag is manually enabled in a local build.
2873 "AutofillCreditCardDropdownVariations")}, 2873 "AutofillCreditCardDropdownVariations")},
2874 {"enable-autofill-credit-card-upload-cvc-prompt", 2874 {"enable-autofill-credit-card-upload-cvc-prompt",
2875 flag_descriptions::kEnableAutofillCreditCardUploadCvcPromptName, 2875 flag_descriptions::kEnableAutofillCreditCardUploadCvcPromptName,
2876 flag_descriptions::kEnableAutofillCreditCardUploadCvcPromptDescription, 2876 flag_descriptions::kEnableAutofillCreditCardUploadCvcPromptDescription,
2877 kOsDesktop, 2877 kOsDesktop,
2878 FEATURE_VALUE_TYPE(autofill::kAutofillUpstreamRequestCvcIfMissing)}, 2878 FEATURE_VALUE_TYPE(autofill::kAutofillUpstreamRequestCvcIfMissing)},
2879 {"enable-autofill-credit-card-upload-new-ui",
2880 flag_descriptions::kEnableAutofillCreditCardUploadNewUiName,
2881 flag_descriptions::kEnableAutofillCreditCardUploadNewUiDescription, kOsAll,
Mathieu 2017/08/09 00:17:23 kOsDesktop?
Jared Saul 2017/08/09 00:24:19 I guess so. I intend this to be usable for Androi
2882 FEATURE_VALUE_TYPE(autofill::kAutofillUpstreamShowNewUi)},
2879 {"enable-autofill-credit-card-bank-name-display", 2883 {"enable-autofill-credit-card-bank-name-display",
2880 flag_descriptions::kEnableAutofillCreditCardBankNameDisplayName, 2884 flag_descriptions::kEnableAutofillCreditCardBankNameDisplayName,
2881 flag_descriptions::kEnableAutofillCreditCardBankNameDisplayDescription, 2885 flag_descriptions::kEnableAutofillCreditCardBankNameDisplayDescription,
2882 kOsAll, FEATURE_VALUE_TYPE(autofill::kAutofillCreditCardBankNameDisplay)}, 2886 kOsAll, FEATURE_VALUE_TYPE(autofill::kAutofillCreditCardBankNameDisplay)},
2883 2887
2884 #if defined(OS_WIN) 2888 #if defined(OS_WIN)
2885 {"windows10-custom-titlebar", 2889 {"windows10-custom-titlebar",
2886 flag_descriptions::kWindows10CustomTitlebarName, 2890 flag_descriptions::kWindows10CustomTitlebarName,
2887 flag_descriptions::kWindows10CustomTitlebarDescription, kOsWin, 2891 flag_descriptions::kWindows10CustomTitlebarDescription, kOsWin,
2888 SINGLE_VALUE_TYPE(switches::kWindows10CustomTitlebar)}, 2892 SINGLE_VALUE_TYPE(switches::kWindows10CustomTitlebar)},
(...skipping 669 matching lines...) Expand 10 before | Expand all | Expand 10 after
3558 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 3562 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
3559 3563
3560 const FeatureEntry* GetFeatureEntries(size_t* count) { 3564 const FeatureEntry* GetFeatureEntries(size_t* count) {
3561 *count = arraysize(kFeatureEntries); 3565 *count = arraysize(kFeatureEntries);
3562 return kFeatureEntries; 3566 return kFeatureEntries;
3563 } 3567 }
3564 3568
3565 } // namespace testing 3569 } // namespace testing
3566 3570
3567 } // namespace about_flags 3571 } // namespace about_flags
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/flag_descriptions.h » ('j') | chrome/browser/flag_descriptions.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698