[vm] Fix reading a named reference to a top-level class.

[vm] Fix reading a named reference to a top-level class.

R=regis@google.com

Committed: https://github.com/dart-lang/sdk/commit/bb621fdf5ab4a23a36eca1fdee5e83c1e549bba7

[rmacnak, 2017-06-26 20:30:30]

rmacnak@google.com changed reviewers:
+ asiva@google.com, regis@google.com

[regis, 2017-06-26 20:30:49]

LGTM

[rmacnak, 2017-06-26 20:34:12]

Description was changed from

==========
[vm] Fix reading a named reference to a top-level class.
==========

to

==========
[vm] Fix reading a named reference to a top-level class.

R=regis@google.com

Committed:
https://github.com/dart-lang/sdk/commit/bb621fdf5ab4a23a36eca1fdee5e83c1e549bba7
==========

[rmacnak, 2017-06-26 20:34:13]

Committed patchset #1 (id:1) manually as
bb621fdf5ab4a23a36eca1fdee5e83c1e549bba7 (presubmit successful).

[siva, 2017-06-26 20:36:45]

lgtm

https://codereview.chromium.org/2955923002/diff/1/runtime/vm/snapshot.cc
File runtime/vm/snapshot.cc (right):

https://codereview.chromium.org/2955923002/diff/1/runtime/vm/snapshot.cc#newc...
runtime/vm/snapshot.cc:282: cls = library_.LookupClassAllowPrivate(str_);
Would it be beneficial to add this login into LookupClassAllowPrivate itself?

[rmacnak, 2017-06-26 20:51:45]

https://codereview.chromium.org/2955923002/diff/1/runtime/vm/snapshot.cc
File runtime/vm/snapshot.cc (right):

https://codereview.chromium.org/2955923002/diff/1/runtime/vm/snapshot.cc#newc...
runtime/vm/snapshot.cc:282: cls = library_.LookupClassAllowPrivate(str_);
On 2017/06/26 20:36:45, siva wrote:
> Would it be beneficial to add this login into LookupClassAllowPrivate itself?

I'm not sure. I don't think we can generally treat library-level lookups as
equivalent to lookups in the corresponding top-level class (I dimly recall that
some top-level members are only added to the library's dictionary and not the
top-level class), so I suspect they usually have to be special-cased anyway.