Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 295583005: Update mojom example files. (Closed)

Created:
6 years, 7 months ago by qsr
Modified:
6 years, 7 months ago
Reviewers:
viettrungluu
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Visibility:
Public.

Description

Update mojom example files. This updates the example mojom files in prevision of the java bindings generator. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271659

Patch Set 1 #

Patch Set 2 : Fix js tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -11 lines) Patch
M mojo/bindings/js/codec_unittests.js View 1 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/math_calculator.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/interfaces/bindings/tests/sample_factory.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/interfaces/bindings/tests/sample_import.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/interfaces/bindings/tests/sample_import2.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/interfaces/bindings/tests/sample_interfaces.mojom View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/interfaces/bindings/tests/sample_service.mojom View 3 chunks +14 lines, -2 lines 0 comments Download
M mojo/public/interfaces/bindings/tests/test_structs.mojom View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
qsr
6 years, 7 months ago (2014-05-19 12:55:11 UTC) #1
viettrungluu
lgtm
6 years, 7 months ago (2014-05-19 20:02:55 UTC) #2
qsr
The CQ bit was checked by qsr@chromium.org
6 years, 7 months ago (2014-05-20 07:41:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/295583005/20001
6 years, 7 months ago (2014-05-20 07:41:39 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 15:35:59 UTC) #5
Message was sent while issue was closed.
Change committed as 271659

Powered by Google App Engine
This is Rietveld 408576698