Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 295583002: tcmalloc: Honor HEAPPROFILE envvar only in profiling=1 builds. (Closed)

Created:
6 years, 7 months ago by Nico
Modified:
6 years, 7 months ago
CC:
chromium-reviews, dmikurube+memory_chromium.org, James Cook, Dai Mikurube (NOT FULLTIME), Hajime Morrita
Visibility:
Public.

Description

tcmalloc: Honor HEAPPROFILE envvar only in profiling=1 builds. Several systems in chromium (about:tracing, some code in blink) use tcmalloc's heap profiler, so keep most of it around. Do disable support for the HEAPPROFILE envvar, and for the exit-time dump to "Exiting" (unless in profiling=1 builds), as that causes a static initializer. BUG=94925 R=willchan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271415

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M third_party/tcmalloc/README.chromium View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/tcmalloc/chromium/src/heap-profiler.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
6 years, 7 months ago (2014-05-19 02:45:35 UTC) #1
Nico
6 years, 7 months ago (2014-05-19 02:48:08 UTC) #2
willchan no longer on Chromium
lgtm
6 years, 7 months ago (2014-05-19 17:17:09 UTC) #3
Nico
6 years, 7 months ago (2014-05-19 17:39:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r271415 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698