Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 2955583003: Update pkg/analyzer dependency on pkg/args to include v1.x (Closed)

Created:
3 years, 6 months ago by kevmoo
Modified:
3 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update pkg/analyzer dependency on pkg/args to include v1.x pkg/analyzer currently does not create an AgrParser so the breaking behavior charge that came w/ the bump to args v1 does not affect any code R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/4d642466fbb70f2fbd290d93b858102239459212

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/analyzer/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
kevmoo
3 years, 6 months ago (2017-06-23 18:34:42 UTC) #2
Brian Wilkerson
lgtm
3 years, 6 months ago (2017-06-23 18:39:40 UTC) #3
kevmoo
3 years, 6 months ago (2017-06-23 18:47:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4d642466fbb70f2fbd290d93b858102239459212 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698