Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2390)

Unified Diff: chrome/browser/resources/md_bookmarks/command_manager.html

Issue 2955563002: MD Bookmarks: Initial screenreader accessibility improvements (Closed)
Patch Set: Hide the undo button when toast is closed Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_bookmarks/command_manager.html
diff --git a/chrome/browser/resources/md_bookmarks/command_manager.html b/chrome/browser/resources/md_bookmarks/command_manager.html
index bc9b3e5b8e71d9469d36f501819e7b6c1a8981e7..b210bbdde66fac9fe4f5ac54118aa3e7603c50bd 100644
--- a/chrome/browser/resources/md_bookmarks/command_manager.html
+++ b/chrome/browser/resources/md_bookmarks/command_manager.html
@@ -27,13 +27,14 @@
}
</style>
<template is="cr-lazy-render" id="dropdown">
- <dialog is="cr-action-menu" on-mousedown="onMenuMousedown_">
+ <dialog is="cr-action-menu" on-mousedown="onMenuMousedown_" role="menu">
<template is="dom-repeat" items="[[menuCommands_]]" as="command">
<button class="dropdown-item"
command$="[[command]]"
hidden$="[[!isCommandVisible_(command, menuIds_)]]"
disabled$="[[!isCommandEnabled_(command, menuIds_)]]"
- on-tap="onCommandClick_">
+ on-tap="onCommandClick_"
+ role="menuitem">
<span class="label">
[[getCommandLabel_(command, menuIds_)]]
</span>

Powered by Google App Engine
This is Rietveld 408576698