tools/testing/dart/command_output.dart - Issue 2955513002: Dynamically load packages for dartdevc tests in test.dart.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testing/dart/command_output.dart

Issue 2955513002: Dynamically load packages for dartdevc tests in test.dart. (Closed)

Patch Set: Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/testing/dart/command_output.dart

diff --git a/tools/testing/dart/command_output.dart b/tools/testing/dart/command_output.dart

index 9b6f6e692c5af19d4f22bdb0abf8736a1b54e075..e6216408b61346866c285c6791397de852b059f4 100644

--- a/tools/testing/dart/command_output.dart

+++ b/tools/testing/dart/command_output.dart

@@ -84,7 +84,6 @@ class CommandOutput extends UniqueObject {

return !hasTimedOut && exitCode == 0;

}

- // TODO(bob): Remove.

// Reverse result of a negative test.

bool hasFailed(TestCase testCase) {

return testCase.isNegative ? !_didFail(testCase) : _didFail(testCase);