Dynamically load packages for dartdevc tests in test.dart.

utils/dartdevc/BUILD.gn

 # Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
 import("../application_snapshot.gni")
+import("../create_timestamp.gni")
 
 application_snapshot("dartdevc") {
   main_dart = "../../pkg/dev_compiler/bin/dartdevc.dart"
   training_args = [
     "--dart-sdk",
     rebase_path("../../sdk"),
     "--dart-sdk-summary",
     rebase_path("../../pkg/dev_compiler/lib/sdk/ddc_sdk.sum"),
     "--library-root",
     rebase_path("../../pkg/dev_compiler"),
@@ skipping 55 matching lines @@
 
 dart2js_compile("dartdevc_web") {
   main = rebase_path("../../pkg/dev_compiler/web/main.dart")
   out = "$root_out_dir/dev_compiler/build/web/ddc_web_compiler.js"
 }
 
 dart2js_compile("stack_trace_mapper") {
   main = rebase_path("../../pkg/dev_compiler/web/stack_trace_mapper.dart")
   out = "$root_out_dir/dev_compiler/build/web/dart_stack_trace_mapper.js"
 }
+
+# Builds everything needed to run dartdevc tests using test.dart.
+group("dartdevc_test") {
+  deps = [
+    "../../sdk:create_sdk",
+    ":dartdevc",

[zra, 2017/06/23 05:00:38]

deps from the current file should come first.

[Bob Nystrom, 2017/06/24 00:29:36]

Done.

+    ":dartdevc_test_pkg",
+  ]
+}
+
+create_timestamp_file("dartdevc_files_stamp") {
+  path = rebase_path("../../pkg/dev_compiler/lib")
+  output = "$target_gen_dir/dartdevc_files.stamp"
+}
+
+# Compiles the packages used by the tests to JS with dartdevc so that they are
+# available for loading by the tests.
+compiled_action("dartdevc_test_pkg") {
+  tool = "../../runtime/bin:dart"
+
+  deps = [
+    ":dartdevc_files_stamp",
+    "../../pkg:pkg_files_stamp",
+  ]
+
+  inputs = [
+    "$target_gen_dir/dartdevc_files.stamp",
+    "$root_gen_dir/pkg_files.stamp",
+  ]
+
+  outputs = [
+    "$root_gen_dir/dartdevc/pkg/async_helper.js",

[zra, 2017/06/23 05:00:38]

$root_gen_dir and $root_out_dir are somewhat valuable real estate, and manually
creating subdirectories of $root_gen_dir is potentially unsafe because they
could conflict with the $target_gen_dir for a BUILD.gn file that someone might
create at //dartdevc, for example.

If at all possible, please use $target_gen_dir here instead. This would make the
output go in out/ReleaseX64/gen/utils/dartdevc/pkg instead of
out/ReleaseX64/gen/dartdevc/pkg.

[Bob Nystrom, 2017/06/24 00:29:36]

I considered that, but this path appears in test.dart since it serves the
resulting files over HTTP for the browser tests. It felt weird to me to have
"utils/dartdevc" in that path since that's an implementation detail of the build
file layout and not relevant to the tests or test.dart.

If you want, I will, but I prefer the shorter path if that's OK.

[zra, 2017/06/26 05:47:33]

Yeah, sorry for the inconvenience, but as far as I'm concerned a shorter path
isn't worth the potential name/path conflicts that this approach can lead to.

[Bob Nystrom, 2017/06/28 23:04:03]

Done.

[zra, 2017/06/29 15:06:00]

Thanks!

+    "$root_gen_dir/dartdevc/pkg/async_helper.sum",
+    "$root_gen_dir/dartdevc/pkg/collection.js",
+    "$root_gen_dir/dartdevc/pkg/collection.sum",
+    "$root_gen_dir/dartdevc/pkg/expect.js",
+    "$root_gen_dir/dartdevc/pkg/expect.sum",
+    "$root_gen_dir/dartdevc/pkg/js.js",
+    "$root_gen_dir/dartdevc/pkg/js.sum",
+    "$root_gen_dir/dartdevc/pkg/matcher.js",
+    "$root_gen_dir/dartdevc/pkg/matcher.sum",
+    "$root_gen_dir/dartdevc/pkg/meta.js",
+    "$root_gen_dir/dartdevc/pkg/meta.sum",
+    "$root_gen_dir/dartdevc/pkg/path.js",
+    "$root_gen_dir/dartdevc/pkg/path.sum",
+    "$root_gen_dir/dartdevc/pkg/stack_trace.js",
+    "$root_gen_dir/dartdevc/pkg/stack_trace.sum",
+    # TODO(rnystrom): Remove this when unittest is no longer used. Also remove
+    # any of the above packages that are only here because unittest uses them.
+    "$root_gen_dir/dartdevc/pkg/unittest.js",
+    "$root_gen_dir/dartdevc/pkg/unittest.sum",
+  ]
+
+  args = [
+    rebase_path("../../pkg/dev_compiler/tool/build_pkgs.dart"),
+    rebase_path("$root_gen_dir/dartdevc/pkg")
+  ]
+}