Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: components/security_interstitials/content/security_interstitial_controller_client.h

Issue 2955503002: Make interstitial links open in a new tab (Closed)
Patch Set: Rebase CL Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/security_interstitials/content/security_interstitial_controller_client.h
diff --git a/components/security_interstitials/content/security_interstitial_controller_client.h b/components/security_interstitials/content/security_interstitial_controller_client.h
index f10d26b08c49d738ad9d6f429c247b11104d7608..969079adbac8a28d4fa34fc3ff256f5c0f2fa9fe 100644
--- a/components/security_interstitials/content/security_interstitial_controller_client.h
+++ b/components/security_interstitials/content/security_interstitial_controller_client.h
@@ -44,11 +44,14 @@ class SecurityInterstitialControllerClient
void GoBackAfterNavigationCommitted() override;
void Proceed() override;
void Reload() override;
+ void OpenUrlInNewForegroundTab(const GURL& url) override;
void OpenUrlInCurrentTab(const GURL& url) override;
PrefService* GetPrefService() override;
const std::string& GetApplicationLocale() const override;
bool CanLaunchDateAndTimeSettings() override;
void LaunchDateAndTimeSettings() override;
+ GURL GetHelpCenterUrl() const override;
+ void SetHelpCenterUrlForTesting(const GURL test_url) override;
meacer 2017/06/23 20:28:32 const GURL& test_url
sperigo 2017/06/23 21:32:11 Done.
protected:
// security_interstitials::ControllerClient overrides.
@@ -62,6 +65,8 @@ class SecurityInterstitialControllerClient
// The default safe page we should go to if there is no previous page to go
// back to, e.g. chrome:kChromeUINewTabURL.
const GURL default_safe_page_;
+ // Link to the help center.
+ GURL help_center_url_;
DISALLOW_COPY_AND_ASSIGN(SecurityInterstitialControllerClient);
};

Powered by Google App Engine
This is Rietveld 408576698