components/security_interstitials/core/superfish_error_ui.cc - Issue 2955503002: Make interstitial links open in a new tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/security_interstitials/core/superfish_error_ui.cc

Issue 2955503002: Make interstitial links open in a new tab (Closed)

Patch Set: Fix compilation error Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/security_interstitials/core/superfish_error_ui.cc

diff --git a/components/security_interstitials/core/superfish_error_ui.cc b/components/security_interstitials/core/superfish_error_ui.cc

index c541249be44db63d7fdb475cf23422746a6b4194..2124319deab60205dcab048e252c573f53d53dff 100644

--- a/components/security_interstitials/core/superfish_error_ui.cc

+++ b/components/security_interstitials/core/superfish_error_ui.cc

@@ -65,7 +65,7 @@ void SuperfishErrorUI::HandleCommand(SecurityInterstitialCommands command) {

if (command == CMD_OPEN_HELP_CENTER) {

controller()->metrics_helper()->RecordUserInteraction(

security_interstitials::MetricsHelper::SHOW_LEARN_MORE);

- controller()->OpenUrlInCurrentTab(GURL(kHelpURL));

+ controller()->OpenUrlInNewForegroundTab(GURL(kHelpURL));

return;

}

SSLErrorUI::HandleCommand(command);