components/security_interstitials/content/security_interstitial_controller_client.cc - Issue 2955503002: Make interstitial links open in a new tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/security_interstitials/content/security_interstitial_controller_client.cc

Issue 2955503002: Make interstitial links open in a new tab (Closed)

Patch Set: Fix compilation error Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/security_interstitials/content/security_interstitial_controller_client.h ('k') | components/security_interstitials/content/security_interstitial_page.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/security_interstitials/content/security_interstitial_controller_client.cc

diff --git a/components/security_interstitials/content/security_interstitial_controller_client.cc b/components/security_interstitials/content/security_interstitial_controller_client.cc

index 87d0789a3912da7f940726d322303a7f59526e8d..49eba9c05d4564301f33a06e6b180706ff4406ff 100644

--- a/components/security_interstitials/content/security_interstitial_controller_client.cc

+++ b/components/security_interstitials/content/security_interstitial_controller_client.cc

@@ -79,6 +79,14 @@ void SecurityInterstitialControllerClient::OpenUrlInCurrentTab(

web_contents_->OpenURL(params);

}

+void SecurityInterstitialControllerClient::OpenUrlInNewForegroundTab(

+ const GURL& url) {

+ content::OpenURLParams params(url, Referrer(),

+ WindowOpenDisposition::NEW_FOREGROUND_TAB,

+ ui::PAGE_TRANSITION_LINK, false);

+ web_contents_->OpenURL(params);

const std::string&

SecurityInterstitialControllerClient::GetApplicationLocale() const {

return app_locale_;