Make interstitial links open in a new tab

components/security_interstitials/content/security_interstitial_controller_client.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/security_interstitials/content/security_interstitial_controller_client.h"
 
 #include <utility>
 
 #include "components/prefs/pref_service.h"
 #include "components/safe_browsing/common/safe_browsing_prefs.h"
 #include "components/security_interstitials/core/metrics_helper.h"
 #include "content/public/browser/interstitial_page.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/referrer.h"
 
 using content::Referrer;
 
 namespace security_interstitials {
 
+// Help Center url

[meacer, 2017/06/23 20:28:32]

nit: End comments with a period.

[sperigo, 2017/06/23 21:32:11]

Done.

+const char kHelpCenterUrl[] = "https://support.google.com/chrome/";
+
 SecurityInterstitialControllerClient::SecurityInterstitialControllerClient(
     content::WebContents* web_contents,
     std::unique_ptr<MetricsHelper> metrics_helper,
     PrefService* prefs,
     const std::string& app_locale,
     const GURL& default_safe_page)
     : ControllerClient(std::move(metrics_helper)),
       web_contents_(web_contents),
       interstitial_page_(nullptr),
       prefs_(prefs),
       app_locale_(app_locale),
-      default_safe_page_(default_safe_page) {}
+      default_safe_page_(default_safe_page) {
+  help_center_url_ = GURL(kHelpCenterUrl);

[meacer, 2017/06/23 20:28:32]

You can move this to the parameter list:

...
default_safe_page_(default_safe_page),
help_center_url_(GURL(kHelpCenterURL)) { // (or maybe even
help_center_url_(kHelpCenterURL)
}

[sperigo, 2017/06/23 21:32:11]

Done.

+}
 
 SecurityInterstitialControllerClient::~SecurityInterstitialControllerClient() {}
 
 void SecurityInterstitialControllerClient::set_interstitial_page(
     content::InterstitialPage* interstitial_page) {
   interstitial_page_ = interstitial_page;
 }
 
 content::InterstitialPage*
 SecurityInterstitialControllerClient::interstitial_page() {
@@ skipping 22 matching lines @@
 }
 
 void SecurityInterstitialControllerClient::Proceed() {
   interstitial_page_->Proceed();
 }
 
 void SecurityInterstitialControllerClient::Reload() {
   web_contents_->GetController().Reload(content::ReloadType::NORMAL, true);
 }
 
+void SecurityInterstitialControllerClient::OpenUrlInNewForegroundTab(
+    const GURL& url) {
+  content::OpenURLParams params(url, Referrer(),
+                                WindowOpenDisposition::NEW_FOREGROUND_TAB,
+                                ui::PAGE_TRANSITION_LINK, false);
+  web_contents_->OpenURL(params);
+}
+
 void SecurityInterstitialControllerClient::OpenUrlInCurrentTab(
     const GURL& url) {
   content::OpenURLParams params(url, Referrer(),
                                 WindowOpenDisposition::CURRENT_TAB,
                                 ui::PAGE_TRANSITION_LINK, false);
   web_contents_->OpenURL(params);
 }
 
 const std::string&
 SecurityInterstitialControllerClient::GetApplicationLocale() const {
@@ skipping 12 matching lines @@
 
 bool SecurityInterstitialControllerClient::CanLaunchDateAndTimeSettings() {
   NOTREACHED();
   return false;
 }
 
 void SecurityInterstitialControllerClient::LaunchDateAndTimeSettings() {
   NOTREACHED();
 }
 
+GURL SecurityInterstitialControllerClient::GetHelpCenterUrl() const {
+  return help_center_url_;
+}
+
+void SecurityInterstitialControllerClient::SetHelpCenterUrlForTesting(
+    const GURL test_url) {

[meacer, 2017/06/23 20:28:32]

const GURL& test_url

[sperigo, 2017/06/23 21:32:11]

Done.

+  help_center_url_ = test_url;
+}
+
 }  // namespace security_interstitials