Allocate the profiler sample buffer and zone segments with virtual memory instead of malloc.

Allocate the profiler sample buffer and zone segments with virtual memory instead of malloc.

Allows naming their memory regions.

Add check for failed sample buffer allocation.

R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/881bf0153475f1edae6ee821aef39556df53f43c

[rmacnak, 2017-06-22 21:40:51]

Description was changed from

==========
Allocate the profiler sample buffer with virtual memory instead of malloc.

Allows giving the memory region a name.

Add check for failed allocation.
==========

to

==========
Allocate the profiler sample buffer and zone segments with virtual memory
instead of malloc.

Allows naming their memory regions.

Add check for failed sample buffer allocation.
==========

[rmacnak, 2017-06-22 21:42:58]

Description was changed from

==========
Allocate the profiler sample buffer and zone segments with virtual memory
instead of malloc.

Allows naming their memory regions.

Add check for failed sample buffer allocation.
==========

to

==========
Allocate the profiler sample buffer and zone segments with virtual memory
instead of malloc.

Allows naming their memory regions.

Add check for failed sample buffer allocation.
==========

[rmacnak, 2017-06-22 22:58:42]

rmacnak@google.com changed reviewers:
+ zra@google.com

[zra, 2017-06-23 04:43:41]

LGTM!

https://codereview.chromium.org/2955493002/diff/40001/runtime/vm/profiler.cc
File runtime/vm/profiler.cc (right):

https://codereview.chromium.org/2955493002/diff/40001/runtime/vm/profiler.cc#...
runtime/vm/profiler.cc:133: intptr_t size = Utils::RoundUp(capacity *
Sample::instance_size(),
const

[zra, 2017-06-23 05:06:19]

Thinking about this more, we should probably check that the Zones change doesn't
cause any performance regressions.

[rmacnak, 2017-06-23 21:03:17]

On 2017/06/23 05:06:19, zra wrote:
> Thinking about this more, we should probably check that the Zones change
doesn't
> cause any performance regressions.

Split out the zones from this CL.

[rmacnak, 2017-06-23 21:05:52]

https://codereview.chromium.org/2955493002/diff/40001/runtime/vm/profiler.cc
File runtime/vm/profiler.cc (right):

https://codereview.chromium.org/2955493002/diff/40001/runtime/vm/profiler.cc#...
runtime/vm/profiler.cc:133: intptr_t size = Utils::RoundUp(capacity *
Sample::instance_size(),
On 2017/06/23 04:43:41, zra wrote:
> const

Done.

[rmacnak, 2017-06-23 21:06:48]

Description was changed from

==========
Allocate the profiler sample buffer and zone segments with virtual memory
instead of malloc.

Allows naming their memory regions.

Add check for failed sample buffer allocation.
==========

to

==========
Allocate the profiler sample buffer and zone segments with virtual memory
instead of malloc.

Allows naming their memory regions.

Add check for failed sample buffer allocation.

R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/881bf0153475f1edae6ee821aef39556df53f43c
==========

[rmacnak, 2017-06-23 21:06:49]

Committed patchset #5 (id:80001) manually as
881bf0153475f1edae6ee821aef39556df53f43c (presubmit successful).

[zra, 2017-06-26 20:30:00]

https://codereview.chromium.org/2955493002/diff/40001/runtime/vm/zone.cc
File runtime/vm/zone.cc (right):

https://codereview.chromium.org/2955493002/diff/40001/runtime/vm/zone.cc#newc...
runtime/vm/zone.cc:26: uword end() { return address(size()); }
Should this be address(size() - sizeof(Segment))?

[rmacnak, 2017-06-26 20:44:43]

https://codereview.chromium.org/2955493002/diff/40001/runtime/vm/zone.cc
File runtime/vm/zone.cc (right):

https://codereview.chromium.org/2955493002/diff/40001/runtime/vm/zone.cc#newc...
runtime/vm/zone.cc:26: uword end() { return address(size()); }
On 2017/06/26 20:30:00, zra wrote:
> Should this be address(size() - sizeof(Segment))?

Hm, the size() calculate should exclude the Segement header.

The zone changes were removed from this CL before landing, although I forgot to
update the commit message to reflect this.