Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: chrome/browser/android/vr_shell/vr_shell.cc

Issue 2955483003: Show splash screen when entering VR from a deep-link (Closed)
Patch Set: . Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/vr_shell/vr_shell.cc
diff --git a/chrome/browser/android/vr_shell/vr_shell.cc b/chrome/browser/android/vr_shell/vr_shell.cc
index 1457dee48d84da5acd48d06e99b11fd3bc75d9f0..27a3a436a300d01f3d7f0ceea590b915fb4ffa56 100644
--- a/chrome/browser/android/vr_shell/vr_shell.cc
+++ b/chrome/browser/android/vr_shell/vr_shell.cc
@@ -56,6 +56,7 @@
#include "ui/base/page_transition_types.h"
#include "ui/display/display.h"
#include "ui/display/screen.h"
+#include "ui/gfx/android/java_bitmap.h"
#include "ui/gfx/codec/png_codec.h"
#include "ui/gfx/geometry/size.h"
#include "ui/gfx/native_widget_types.h"
@@ -94,7 +95,7 @@ VrShell::VrShell(JNIEnv* env,
jobject obj,
ui::WindowAndroid* window,
bool for_web_vr,
- bool web_vr_autopresented,
+ bool web_vr_autopresentation_expected,
bool in_cct,
VrShellDelegate* delegate,
gvr_context* gvr_api,
@@ -114,8 +115,8 @@ VrShell::VrShell(JNIEnv* env,
gl_thread_ = base::MakeUnique<VrGLThread>(
weak_ptr_factory_.GetWeakPtr(), main_thread_task_runner_, gvr_api,
- for_web_vr, web_vr_autopresented, in_cct, reprojected_rendering_,
- HasDaydreamSupport(env));
+ for_web_vr, web_vr_autopresentation_expected, in_cct,
+ reprojected_rendering_, HasDaydreamSupport(env));
ui_ = gl_thread_.get();
base::Thread::Options options(base::MessageLoop::TYPE_DEFAULT, 0);
@@ -123,6 +124,13 @@ VrShell::VrShell(JNIEnv* env,
gl_thread_->StartWithOptions(options);
}
+void VrShell::SetSplashScreenIcon(JNIEnv* env,
+ const JavaParamRef<jobject>& obj,
+ const JavaParamRef<jobject>& bitmap) {
+ ui_->SetSplashScreenIcon(
+ gfx::CreateSkBitmapFromJavaBitmap(gfx::JavaBitmap(bitmap)));
+}
+
void VrShell::Destroy(JNIEnv* env, const JavaParamRef<jobject>& obj) {
delete this;
}
@@ -337,15 +345,14 @@ void VrShell::SetSurface(JNIEnv* env,
void VrShell::SetWebVrMode(JNIEnv* env,
const JavaParamRef<jobject>& obj,
- bool enabled,
- bool auto_presented) {
+ bool enabled) {
webvr_mode_ = enabled;
if (metrics_helper_)
metrics_helper_->SetWebVREnabled(enabled);
WaitForGlThread();
PostToGlThread(FROM_HERE, base::Bind(&VrShellGl::SetWebVrMode,
gl_thread_->GetVrShellGl(), enabled));
- ui_->SetWebVrMode(enabled, auto_presented);
+ ui_->SetWebVrMode(enabled);
}
void VrShell::OnFullscreenChanged(bool enabled) {
@@ -733,13 +740,13 @@ jlong Init(JNIEnv* env,
const JavaParamRef<jobject>& delegate,
jlong window_android,
jboolean for_web_vr,
- jboolean web_vr_autopresented,
+ jboolean web_vr_autopresentation_expected,
jboolean in_cct,
jlong gvr_api,
jboolean reprojected_rendering) {
return reinterpret_cast<intptr_t>(new VrShell(
env, obj, reinterpret_cast<ui::WindowAndroid*>(window_android),
- for_web_vr, web_vr_autopresented, in_cct,
+ for_web_vr, web_vr_autopresentation_expected, in_cct,
VrShellDelegate::GetNativeVrShellDelegate(env, delegate),
reinterpret_cast<gvr_context*>(gvr_api), reprojected_rendering));
}

Powered by Google App Engine
This is Rietveld 408576698