Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1076)

Unified Diff: chrome/browser/chromeos/system_logs/single_debug_daemon_log_source_unittest.cc

Issue 2955463002: Add log source to read from one DebugDaemon log (Closed)
Patch Set: Rebased: updated to latest DebugDaemonClient; Browser thread bundle Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/system_logs/single_debug_daemon_log_source.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/system_logs/single_debug_daemon_log_source_unittest.cc
diff --git a/chrome/browser/chromeos/system_logs/single_debug_daemon_log_source_unittest.cc b/chrome/browser/chromeos/system_logs/single_debug_daemon_log_source_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..4b7b4fb43017902a62d3becf4f4e63c78a804259
--- /dev/null
+++ b/chrome/browser/chromeos/system_logs/single_debug_daemon_log_source_unittest.cc
@@ -0,0 +1,154 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/chromeos/system_logs/single_debug_daemon_log_source.h"
+
+#include <string>
+
+#include "base/bind.h"
+#include "base/macros.h"
+#include "base/memory/ptr_util.h"
+#include "base/run_loop.h"
+#include "base/test/scoped_task_environment.h"
+#include "chromeos/dbus/dbus_thread_manager.h"
+#include "chromeos/dbus/fake_debug_daemon_client.h"
+#include "content/public/test/test_browser_thread_bundle.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace system_logs {
+
+using SupportedSource = SingleDebugDaemonLogSource::SupportedSource;
+
+class SingleDebugDaemonLogSourceTest : public ::testing::Test {
+ public:
+ SingleDebugDaemonLogSourceTest()
+ : scoped_task_environment_(
+ base::test::ScopedTaskEnvironment::MainThreadType::UI),
+ fetch_callback_(
+ base::Bind(&SingleDebugDaemonLogSourceTest::OnFetchComplete,
+ base::Unretained(this))),
+ num_callback_calls_(0) {}
+
+ void SetUp() override {
+ // Since no debug daemon will be available during a unit test, use
+ // FakeDebugDaemonClient to provide dummy DebugDaemonClient functionality.
+ chromeos::DBusThreadManager::GetSetterForTesting()->SetDebugDaemonClient(
+ base::MakeUnique<chromeos::FakeDebugDaemonClient>());
+ }
+
+ void TearDown() override {
+ chromeos::DBusThreadManager::GetSetterForTesting()->SetDebugDaemonClient(
+ nullptr);
+ }
+
+ protected:
+ const SysLogsSourceCallback& fetch_callback() const {
+ return fetch_callback_;
+ }
+
+ int num_callback_calls() const { return num_callback_calls_; }
+
+ const SystemLogsResponse& response() const { return response_; }
+
+ void ClearResponse() { response_.clear(); }
+
+ private:
+ void OnFetchComplete(SystemLogsResponse* response) {
+ ++num_callback_calls_;
+ response_ = *response;
+ }
+
+ // For running scheduled tasks.
+ base::test::ScopedTaskEnvironment scoped_task_environment_;
+
+ // Creates the necessary browser threads. Defined after
+ // |scoped_task_environment_| in order to use the MessageLoop it created.
+ content::TestBrowserThreadBundle browser_thread_bundle_;
+
+ // Pre-made callback object for passing OnFetchComplete() to an asynchronous
+ // function.
+ const SysLogsSourceCallback fetch_callback_;
+
+ // Used to verify that OnFetchComplete was called the correct number of times.
+ int num_callback_calls_;
+
+ // Stores results from the log source.
+ SystemLogsResponse response_;
+
+ DISALLOW_COPY_AND_ASSIGN(SingleDebugDaemonLogSourceTest);
+};
+
+TEST_F(SingleDebugDaemonLogSourceTest, SingleCall) {
+ SingleDebugDaemonLogSource source(SupportedSource::kModetest);
+
+ source.Fetch(fetch_callback());
+ base::RunLoop().RunUntilIdle();
+
+ EXPECT_EQ(1, num_callback_calls());
+ ASSERT_EQ(1U, response().size());
+
+ EXPECT_EQ("modetest", response().begin()->first);
+ EXPECT_EQ("modetest: response from GetLog", response().begin()->second);
+}
+
+TEST_F(SingleDebugDaemonLogSourceTest, MultipleCalls) {
+ SingleDebugDaemonLogSource source(SupportedSource::kLsusb);
+
+ source.Fetch(fetch_callback());
+ base::RunLoop().RunUntilIdle();
+
+ EXPECT_EQ(1, num_callback_calls());
+ ASSERT_EQ(1U, response().size());
+
+ EXPECT_EQ("lsusb", response().begin()->first);
+ EXPECT_EQ("lsusb: response from GetLog", response().begin()->second);
+
+ ClearResponse();
+
+ source.Fetch(fetch_callback());
+ base::RunLoop().RunUntilIdle();
+
+ EXPECT_EQ(2, num_callback_calls());
+ ASSERT_EQ(1U, response().size());
+
+ EXPECT_EQ("lsusb", response().begin()->first);
+ EXPECT_EQ("lsusb: response from GetLog", response().begin()->second);
+
+ ClearResponse();
+
+ source.Fetch(fetch_callback());
+ base::RunLoop().RunUntilIdle();
+
+ EXPECT_EQ(3, num_callback_calls());
+ ASSERT_EQ(1U, response().size());
+
+ EXPECT_EQ("lsusb", response().begin()->first);
+ EXPECT_EQ("lsusb: response from GetLog", response().begin()->second);
+}
+
+TEST_F(SingleDebugDaemonLogSourceTest, MultipleSources) {
+ SingleDebugDaemonLogSource source1(SupportedSource::kModetest);
+ source1.Fetch(fetch_callback());
+ base::RunLoop().RunUntilIdle();
+
+ EXPECT_EQ(1, num_callback_calls());
+ ASSERT_EQ(1U, response().size());
+
+ EXPECT_EQ("modetest", response().begin()->first);
+ EXPECT_EQ("modetest: response from GetLog", response().begin()->second);
+
+ ClearResponse();
+
+ SingleDebugDaemonLogSource source2(SupportedSource::kLsusb);
+ source2.Fetch(fetch_callback());
+ base::RunLoop().RunUntilIdle();
+
+ EXPECT_EQ(2, num_callback_calls());
+ ASSERT_EQ(1U, response().size());
+
+ EXPECT_EQ("lsusb", response().begin()->first);
+ EXPECT_EQ("lsusb: response from GetLog", response().begin()->second);
+}
+
+} // namespace system_logs
« no previous file with comments | « chrome/browser/chromeos/system_logs/single_debug_daemon_log_source.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698