Issue 2955313003: Use SearchEngine.membersOfSubtypes() instead of actual elements in ImplementedComputer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2955313003: Use SearchEngine.membersOfSubtypes() instead of actual elements in ImplementedComputer. (Closed)

Created:
3 years, 5 months ago by scheglov

Modified:
3 years, 5 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Use SearchEngine.membersOfSubtypes() instead of actual elements in ImplementedComputer. This makes 'implemented' notification 10x faster for files with many types and implemented methods, like visitor.dart - from 400 ms down to 36 ms. Still not as fast as I would like, but much better. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/8f5c21ea68c28255d17050a9b5815e8572adafe7

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -21 lines)			Patch
	M	pkg/analysis_server/lib/src/domains/analysis/implemented_dart.dart	View		3 chunks	+10 lines, -21 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

3 years, 5 months ago (2017-06-29 17:11:32 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8f5c21ea68c28255d17050a9b5815e8572adafe7 (presubmit successful).