Source/bindings/v8/custom/V8HTMLImageElementConstructor.cpp - Issue 29553002: Move privateTemplateUniqueKey / sharedTemplateUniqueKey to .bss section

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/custom/V8HTMLImageElementConstructor.cpp

Issue 29553002: Move privateTemplateUniqueKey / sharedTemplateUniqueKey to .bss section (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Update sharedTemplateUniqueKey as well Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/custom/V8HTMLImageElementConstructor.cpp

diff --git a/Source/bindings/v8/custom/V8HTMLImageElementConstructor.cpp b/Source/bindings/v8/custom/V8HTMLImageElementConstructor.cpp

index 8d06c793899eaecbb1d5a31eeb831e323f1e9c22..b4db1220e15d944c4548fd49d458a205debb43b0 100644

--- a/Source/bindings/v8/custom/V8HTMLImageElementConstructor.cpp

+++ b/Source/bindings/v8/custom/V8HTMLImageElementConstructor.cpp

@@ -89,7 +89,7 @@ static void v8HTMLImageElementConstructorMethodCustom(const v8::FunctionCallback

v8::Handle<v8::FunctionTemplate> V8HTMLImageElementConstructor::GetTemplate(v8::Isolate* isolate, WrapperWorldType currentWorldType)

{

// This is only for getting a unique pointer which we can pass to privateTemplate.

- static const char* privateTemplateUniqueKey = "V8HTMLImageElementConstructor::GetTemplatePrivateTemplate";

+ static const int privateTemplateUniqueKey = 0;

V8PerIsolateData* data = V8PerIsolateData::from(isolate);

v8::Handle<v8::FunctionTemplate> result = data->privateTemplateIfExists(currentWorldType, &privateTemplateUniqueKey);

if (!result.IsEmpty())