ui: Fix usage of desktop_linux in our grd files.

ui: Fix usage of desktop_linux in our grd files.

Its use confuses gn, because gn does not have this concept of
desktop_linux. There it is defined as is_linux && !is_chromeos. Use that
in our grd files and get rid of desktop_linux usage.

This may break BSDs and Solaris, but who really cares? We don't have
configs on the bots supporting that platforms.

BUG=367591
TEST=None
R=brettw@chromium.org,oshima@chromium.org

[tfarina, 2014-05-17 20:02:21]

ptal.

Thanks,

[oshima, 2014-05-18 16:16:22]

i think erg@ should review this.

I'm not familiar with gn and I didn't fully understand what you mean by "gn does
not have this concept of desktop_linux", but desktop_linux is used in other
places, and just removing this form specific files seems confusing to me.

[tfarina, 2014-05-18 21:11:04]

On Sun, May 18, 2014 at 1:16 PM, <oshima@chromium.org> wrote:

> i think erg@ should review this.
>
> I'm not familiar with gn and I didn't fully understand what you mean by
> "gn does
> not have this concept of desktop_linux"

By this I mean we don't declare a variable called desktop_linux = is_linux
|| freebsd || openbsd || solaris && !is_chromeos or even just is_linux &&
!is_chromeos. That is what I mean.


> , but desktop_linux is used in other places, and just removing this form
> specific files seems confusing to me.

I'm just removing from these specific files because as I said in the bug I
need to get IDS_WEB_FONT_FAMILY defined. I didn't bother updating other
places because they are not relevant for this bug at this moment and would
cause just (unnecessarily) noise.

And that is what this patch does.

Thanks!

-- 
Thiago Farina

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Elliot Glaysher, 2014-05-19 18:16:45]

This doesn't look correct and conflicts with bug 290185.

[tfarina, 2014-05-19 18:53:18]

On Mon, May 19, 2014 at 3:16 PM, <erg@chromium.org> wrote:

> This doesn't look correct and conflicts with bug 290185.
>
> What would be the correct thing to do here?


> https://codereview.chromium.org/295523002/
>



-- 
Thiago Farina

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[tfarina, 2014-05-20 20:00:33]

Elliot, ping?

[Elliot Glaysher, 2014-05-20 20:04:12]

On 2014/05/20 20:00:33, tfarina wrote:
> Elliot, ping?

I don't know what the correct solution is. Probably whatever defines
desktop_linux in gn. I don't know enough about gn to meaningfully talk about
that part.

[tfarina, 2014-05-20 20:10:10]

On Tue, May 20, 2014 at 5:04 PM, <erg@chromium.org> wrote:

> On 2014/05/20 20:00:33, tfarina wrote:
>
>> Elliot, ping?
>>
>
> I don't know what the correct solution is. Probably whatever defines
> desktop_linux in gn.

But I have already told Oshima about this early. See previous messages in
this patch.

https://code.google.com/p/chromium/wiki/GNCookbook - Ctrl+F, then type
desktop_linux.

I copied you in the e-mail Brett sent to me.

-- 
Thiago Farina

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[oshima, 2014-05-20 20:20:20]

On 2014/05/20 20:10:10, tfarina wrote:
> On Tue, May 20, 2014 at 5:04 PM, <mailto:erg@chromium.org> wrote:
> 
> > On 2014/05/20 20:00:33, tfarina wrote:
> >
> >> Elliot, ping?
> >>
> >
> > I don't know what the correct solution is. Probably whatever defines
> > desktop_linux in gn.
> 
> But I have already told Oshima about this early. See previous messages in
> this patch.
> 
> https://code.google.com/p/chromium/wiki/GNCookbook - Ctrl+F, then type
> desktop_linux.
> 
> I copied you in the e-mail Brett sent to me.

What prevent us from defining desktop_linux in GN? What about use_ash or what if
we have
another configuration?

> 
> -- 
> Thiago Farina
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[tfarina, 2014-05-20 20:47:34]

On 2014/05/20 20:20:20, oshima wrote:
> On 2014/05/20 20:10:10, tfarina wrote:
> > On Tue, May 20, 2014 at 5:04 PM, <mailto:erg@chromium.org> wrote:
> > 
> > > On 2014/05/20 20:00:33, tfarina wrote:
> > >
> > >> Elliot, ping?
> > >>
> > >
> > > I don't know what the correct solution is. Probably whatever defines
> > > desktop_linux in gn.
> > 
> > But I have already told Oshima about this early. See previous messages in
> > this patch.
> > 
> > https://code.google.com/p/chromium/wiki/GNCookbook - Ctrl+F, then type
> > desktop_linux.
> > 
> > I copied you in the e-mail Brett sent to me.
> 
> What prevent us from defining desktop_linux in GN?

I think what prevent us (me in this case) is Brett's call. I need his approval
to define it in GN and from his email I was under the impression that he didn't
want to define it in GN, so I went to the other side.

Brett, could you make a call here?

Thanks,

[brettw, 2014-05-21 21:02:54]

From talking to people, I thought there was some general unhappiness about the
desktop_linux flag and it was relevant only for unsupported build
configurations. Is this not correct?

[Elliot Glaysher, 2014-05-21 21:20:32]

The desktop_linux flag is used to compile assets into the desktop linux build;
aka the one we ship on desktop linux.

[tfarina, 2014-05-22 01:20:54]

On Wed, May 21, 2014 at 6:20 PM, <erg@chromium.org> wrote:

> The desktop_linux flag is used to compile assets into the desktop linux
> build;
> aka the one we ship on desktop linux.
>
> Elliot, I'm not understanding your point. What is so bad of using
'is_linux and not chromeos' in the grd files? By doing that I'm excluding
freebsd, openbsd and solaris, which (afaik) we don't have bot coverage. So
what is the problem I'm missing here?

https://chromium.googlesource.com/chromium/chromium/+/trunk/build/common.gypi...

https://codereview.chromium.org/295523002/
>

-- 
Thiago Farina

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[tfarina, 2014-05-23 03:16:23]

Elliot, ping?

[Elliot Glaysher, 2014-05-23 18:08:08]

On 2014/05/23 03:16:23, tfarina wrote:
> Elliot, ping?

The fact that we want to minimize the amount of work the bsd and solaris people
have to do. There was a big push a while back to rename as many of the _linux.*
files which didn't depend on linux kernel headers to, say, _x11.*, to actually
reflect what they were using.

Moreover, having an explicit flag for this configuration is more explicit and is
easier to reason about.

[tfarina, 2014-05-23 19:37:41]

On 2014/05/23 18:08:08, Elliot Glaysher wrote:
> On 2014/05/23 03:16:23, tfarina wrote:
> > Elliot, ping?
> 
> The fact that we want to minimize the amount of work the bsd and solaris
people
> have to do. There was a big push a while back to rename as many of the
_linux.*
> files which didn't depend on linux kernel headers to, say, _x11.*, to actually
> reflect what they were using.
> 
> Moreover, having an explicit flag for this configuration is more explicit and
is
> easier to reason about.

Brett, is https://codereview.chromium.org/296933017/ acceptable in that case?