Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2955173002: [subresource_filter] Updates Dev Tools messages. (Closed)

Created:
3 years, 5 months ago by shivanisha
Modified:
3 years, 5 months ago
CC:
blink-reviews, chromium-reviews, darin-cc_chromium.org, jam, subresource-filter-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[subresource_filter] Updates Dev Tools messages. BUG=724549 Review-Url: https://codereview.chromium.org/2955173002 Cr-Commit-Position: refs/heads/master@{#482976} Committed: https://chromium.googlesource.com/chromium/src/+/a4f88bdad6d5b47e1f9f022ecda09b0909af6852

Patch Set 1 #

Patch Set 2 : Initial patch #

Messages

Total messages: 21 (13 generated)
shivanisha
csharrison@, PTAL, Thanks!
3 years, 5 months ago (2017-06-27 20:01:05 UTC) #6
Charlie Harrison
LGTM
3 years, 5 months ago (2017-06-27 20:33:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2955173002/20001
3 years, 5 months ago (2017-06-27 22:28:51 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/475446)
3 years, 5 months ago (2017-06-27 22:38:11 UTC) #13
shivanisha
rbyers@, PTAL for owner approval of third_party/WebKit/Source/core/loader/SubresourceFilter.cpp The change in this file just updates the ...
3 years, 5 months ago (2017-06-27 23:37:12 UTC) #15
Rick Byers
On 2017/06/27 23:37:12, shivanisha wrote: > rbyers@, PTAL for owner approval of > third_party/WebKit/Source/core/loader/SubresourceFilter.cpp > ...
3 years, 5 months ago (2017-06-28 13:52:34 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2955173002/20001
3 years, 5 months ago (2017-06-28 14:10:02 UTC) #18
commit-bot: I haz the power
3 years, 5 months ago (2017-06-28 14:15:33 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a4f88bdad6d5b47e1f9f022ecda0...

Powered by Google App Engine
This is Rietveld 408576698