Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2955163002: Store subtyped names in Analysis Driver unlinked units. (Closed)

Created:
3 years, 5 months ago by scheglov
Modified:
3 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Store subtyped names in Analysis Driver unlinked units. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/dcc66e6fa96050adb06eebb19756780ed2f9d184

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -2 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/file_state.dart View 4 chunks +12 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.dart View 11 chunks +40 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/summary/format.fbs View Binary file 0 comments Download
M pkg/analyzer/lib/src/summary/idl.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/dart/analysis/file_state_test.dart View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 5 months ago (2017-06-27 19:26:18 UTC) #1
Brian Wilkerson
lgtm
3 years, 5 months ago (2017-06-27 19:38:04 UTC) #2
scheglov
3 years, 5 months ago (2017-06-27 19:38:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
dcc66e6fa96050adb06eebb19756780ed2f9d184 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698