Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/shell/common/layout_test.mojom

Issue 2955123002: Mojo-ify ShellViewHostMsg_LayoutDumpResponse. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/shell/browser/layout_test/blink_test_controller.h ('K') | « content/shell/browser/layout_test/blink_test_controller.cc ('k') | content/shell/common/shell_messages.h » ('j') | content/shell/common/shell_messages.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/shell/common/layout_test.mojom
diff --git a/content/shell/common/layout_test.mojom b/content/shell/common/layout_test.mojom
index dd61553f4ecc53ef400cb7fb93457871bbca441e..6c7c6af9fcb2d4ae496b5bf52a7e357af6b8a3e5 100644
--- a/content/shell/common/layout_test.mojom
+++ b/content/shell/common/layout_test.mojom
@@ -37,7 +37,7 @@ struct ShellTestConfiguration {
interface LayoutTestControl {
// Asks a frame to dump its contents into a string and send them back over
// IPC.
alexmos 2017/06/27 21:35:48 nit: s/them/it/ and perhaps remove "over IPC"
Łukasz Anforowicz 2017/06/27 22:17:41 I've changed the entire comment.
- LayoutDumpRequest();
+ DumpFrameLayout() => (string frame_layout_dump);
// Replicates test config (for an already started test) to a new renderer
// that hosts parts of the main test window.
« content/shell/browser/layout_test/blink_test_controller.h ('K') | « content/shell/browser/layout_test/blink_test_controller.cc ('k') | content/shell/common/shell_messages.h » ('j') | content/shell/common/shell_messages.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698