Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 2955093002: Split KernelToElementMap mixins to match interfaces (Closed)

Created:
3 years, 5 months ago by Johnni Winther
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -1245 lines) Patch
M pkg/compiler/lib/src/kernel/element_map.dart View 7 chunks +12 lines, -836 lines 0 comments Download
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 4 chunks +8 lines, -8 lines 0 comments Download
A + pkg/compiler/lib/src/kernel/element_map_mixins.dart View 18 chunks +115 lines, -397 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/kernel/impact_test.dart View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 5 months ago (2017-06-27 13:39:14 UTC) #2
Siggi Cherem (dart-lang)
lgtm
3 years, 5 months ago (2017-06-27 20:22:34 UTC) #3
Johnni Winther
3 years, 5 months ago (2017-06-28 07:43:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a9fca6fba9fe4c5b8d668f6d29e0d10654e5d168 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698