VM-codegen: Add IL instruction to check if a Smi is in a constant range

runtime/vm/intermediate_language.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/intermediate_language.h"
 
 #include "vm/bit_vector.h"
 #include "vm/bootstrap.h"
 #include "vm/compiler.h"
 #include "vm/constant_propagator.h"
@@ skipping 2960 matching lines @@
 
   // Spread class-ids to preceding classes where a lookup yields the same
   // method.  A polymorphic target is not really the same method since its
   // behaviour depends on the receiver class-id, so we don't spread the
   // class-ids in that case.
   for (int idx = 0; idx < length; idx++) {
     int lower_limit_cid = (idx == 0) ? -1 : targets[idx - 1].cid_end;
     const Function& target = *targets.TargetAt(idx)->target;
     if (MethodRecognizer::PolymorphicTarget(target)) continue;
     for (int i = targets[idx].cid_start - 1; i > lower_limit_cid; i--) {
-      if (FlowGraphCompiler::LookupMethodFor(i, name, args_desc, &fn) &&
+      bool class_is_abstract = false;
+      if (FlowGraphCompiler::LookupMethodFor(i, name, args_desc, &fn,
+                                             &class_is_abstract) &&
           fn.raw() == target.raw()) {
-        targets[idx].cid_start = i;
+        if (!class_is_abstract) {
+          targets[idx].cid_start = i;
+        }
       } else {
         break;
       }
     }
   }
   // Spread class-ids to following classes where a lookup yields the same
   // method.
   for (int idx = 0; idx < length; idx++) {
     int upper_limit_cid =
         (idx == length - 1) ? 1000000000 : targets[idx + 1].cid_start;
     const Function& target = *targets.TargetAt(idx)->target;
     if (MethodRecognizer::PolymorphicTarget(target)) continue;
     for (int i = targets[idx].cid_end + 1; i < upper_limit_cid; i++) {
-      if (FlowGraphCompiler::LookupMethodFor(i, name, args_desc, &fn) &&
+      bool class_is_abstract = false;
+      if (FlowGraphCompiler::LookupMethodFor(i, name, args_desc, &fn,
+                                             &class_is_abstract) &&
           fn.raw() == target.raw()) {
-        targets[idx].cid_end = i;
+        if (!class_is_abstract) {
+          targets[idx].cid_end = i;
+        }
       } else {
         break;
       }
     }
   }
   targets.MergeIntoRanges();
   return &targets;
 }
 
 
@@ skipping 868 matching lines @@
 }
 
 
 ComparisonInstr* DoubleTestOpInstr::CopyWithNewOperands(Value* new_left,
                                                         Value* new_right) {
   UNREACHABLE();
   return NULL;
 }
 
 
+ComparisonInstr* SmiRangeComparisonInstr::CopyWithNewOperands(
+    Value* new_left,
+    Value* new_right) {
+  UNREACHABLE();
+  return NULL;
+}
+
+
 ComparisonInstr* EqualityCompareInstr::CopyWithNewOperands(Value* new_left,
                                                            Value* new_right) {
   return new EqualityCompareInstr(token_pos(), kind(), new_left, new_right,
                                   operation_cid(), deopt_id());
 }
 
 
 ComparisonInstr* RelationalOpInstr::CopyWithNewOperands(Value* new_left,
                                                         Value* new_right) {
   return new RelationalOpInstr(token_pos(), kind(), new_left, new_right,
@@ skipping 495 matching lines @@
                      "native function '%s' (%" Pd " arguments) cannot be found",
                      native_name().ToCString(), function().NumParameters());
   }
   set_is_auto_scope(auto_setup_scope);
   set_native_c_function(native_function);
 }
 
 #undef __
 
 }  // namespace dart