Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: tracing/tracing/value/ui/scalar_span_test.html

Issue 2955043002: Remove tr.b.asArray. (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/value/ui/scalar_context_controller_test.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/value/ui/scalar_span_test.html
diff --git a/tracing/tracing/value/ui/scalar_span_test.html b/tracing/tracing/value/ui/scalar_span_test.html
index 340572c31a5a2894e4517aabc6f3ced66f9fbe60..64575d3fb82cf628c91ccc8f316bfde947eac881 100644
--- a/tracing/tracing/value/ui/scalar_span_test.html
+++ b/tracing/tracing/value/ui/scalar_span_test.html
@@ -510,7 +510,7 @@ tr.b.unittest.testSuite(function() {
assert.closeTo(parseFloat(computedStyle.left), expectation.left, 0.1);
assert.closeTo(parseFloat(computedStyle.width), expectation.width, 0.1);
- assert.sameMembers(tr.b.asArray(sparklineEl.classList),
+ assert.sameMembers(Array.from(sparklineEl.classList),
expectation.classList || []);
}
@@ -914,56 +914,56 @@ tr.b.unittest.testSuite(function() {
});
Polymer.dom(div).appendChild(span);
- assert.sameMembers(tr.b.asArray(span.$.content.classList), ['worse']);
+ assert.sameMembers(Array.from(span.$.content.classList), ['worse']);
checkSignificance(span, 'significantly_worse');
span.significance = tr.b.math.Statistics.Significance.DONT_CARE;
- assert.sameMembers(tr.b.asArray(span.$.sparkline.classList),
+ assert.sameMembers(Array.from(span.$.sparkline.classList),
['positive', 'worse']);
- assert.sameMembers(tr.b.asArray(span.$.content.classList), ['worse']);
+ assert.sameMembers(Array.from(span.$.content.classList), ['worse']);
checkSignificance(span, '');
span.value = -5;
- assert.sameMembers(tr.b.asArray(span.$.sparkline.classList), ['better']);
- assert.sameMembers(tr.b.asArray(span.$.content.classList), ['better']);
+ assert.sameMembers(Array.from(span.$.sparkline.classList), ['better']);
+ assert.sameMembers(Array.from(span.$.content.classList), ['better']);
checkSignificance(span, '');
span.unit = Unit.byName.energyInJoules;
- assert.sameMembers(tr.b.asArray(span.$.sparkline.classList), []);
- assert.sameMembers(tr.b.asArray(span.$.content.classList), []);
+ assert.sameMembers(Array.from(span.$.sparkline.classList), []);
+ assert.sameMembers(Array.from(span.$.content.classList), []);
checkSignificance(span, '');
span.value = 20;
- assert.sameMembers(tr.b.asArray(span.$.sparkline.classList), ['positive']);
- assert.sameMembers(tr.b.asArray(span.$.content.classList), []);
+ assert.sameMembers(Array.from(span.$.sparkline.classList), ['positive']);
+ assert.sameMembers(Array.from(span.$.content.classList), []);
checkSignificance(span, '');
span.unit = Unit.byName.energyInJoulesDelta_biggerIsBetter;
- assert.sameMembers(tr.b.asArray(span.$.sparkline.classList),
+ assert.sameMembers(Array.from(span.$.sparkline.classList),
['positive', 'better']);
- assert.sameMembers(tr.b.asArray(span.$.content.classList), ['better']);
+ assert.sameMembers(Array.from(span.$.content.classList), ['better']);
checkSignificance(span, '');
span.significance = tr.b.math.Statistics.Significance.INSIGNIFICANT;
- assert.sameMembers(tr.b.asArray(span.$.sparkline.classList),
+ assert.sameMembers(Array.from(span.$.sparkline.classList),
['positive', 'better']);
- assert.sameMembers(tr.b.asArray(span.$.content.classList), ['better']);
+ assert.sameMembers(Array.from(span.$.content.classList), ['better']);
checkSignificance(span, 'insignificant');
span.unit = Unit.byName.energyInJoulesDelta_smallerIsBetter;
- assert.sameMembers(tr.b.asArray(span.$.sparkline.classList),
+ assert.sameMembers(Array.from(span.$.sparkline.classList),
['positive', 'worse']);
- assert.sameMembers(tr.b.asArray(span.$.content.classList), ['worse']);
+ assert.sameMembers(Array.from(span.$.content.classList), ['worse']);
checkSignificance(span, 'insignificant');
span.unit = Unit.byName.energyInJoulesDelta;
- assert.sameMembers(tr.b.asArray(span.$.sparkline.classList), ['positive']);
- assert.sameMembers(tr.b.asArray(span.$.content.classList), []);
+ assert.sameMembers(Array.from(span.$.sparkline.classList), ['positive']);
+ assert.sameMembers(Array.from(span.$.content.classList), []);
checkSignificance(span, '');
span.value = 0;
- assert.sameMembers(tr.b.asArray(span.$.sparkline.classList), []);
- assert.sameMembers(tr.b.asArray(span.$.content.classList), []);
+ assert.sameMembers(Array.from(span.$.sparkline.classList), []);
+ assert.sameMembers(Array.from(span.$.content.classList), []);
checkSignificance(span, '');
});
« no previous file with comments | « tracing/tracing/value/ui/scalar_context_controller_test.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698